Andal.LND/edx-platform
6
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Adding legacy event_type for language menu events

Browse Source
This commit is contained in:
Chris Rodriguez
2016-04-22 12:27:54 -04:00
committed by Clinton Blackburn
parent 921dc602ba
commit d68e50a502
4 changed files with 9 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
common/djangoapps/track/transformers.py
View File

@@ -374,6 +374,8 @@ class VideoEventTransformer(EventTransformer):
u'edx.video.seeked': u'seek_video',
u'edx.video.transcript.shown': u'show_transcript',
u'edx.video.transcript.hidden': u'hide_transcript',
u'edx.video.language_menu.shown': u'video_show_cc_menu',
u'edx.video.language_menu.hidden': u'video_hide_cc_menu',
}
is_legacy_event = True

8
common/lib/xmodule/xmodule/js/spec/video/video_events_plugin_spec.js
View File

@@ -117,17 +117,17 @@
});
});
it('can emit "video_show_cc_menu" event', function () {
it('can emit "edx.video.language_menu.shown" event', function () {
state.el.trigger('language_menu:show');
expect(Logger.log).toHaveBeenCalledWith('video_show_cc_menu', {
expect(Logger.log).toHaveBeenCalledWith('edx.video.language_menu.shown', {
id: 'id',
code: 'html5'
});
});
it('can emit "video_hide_cc_menu" event', function () {
it('can emit "edx.video.language_menu.hidden" event', function () {
state.el.trigger('language_menu:hide');
expect(Logger.log).toHaveBeenCalledWith('video_hide_cc_menu', {
expect(Logger.log).toHaveBeenCalledWith('edx.video.language_menu.hidden', {
id: 'id',
code: 'html5',
language: 'en'

4
common/lib/xmodule/xmodule/js/src/video/09_events_plugin.js
View File

@@ -105,11 +105,11 @@ define('video/09_events_plugin.js', [], function() {
},
onShowLanguageMenu: function () {
this.log('video_show_cc_menu');
this.log('edx.video.language_menu.shown');
},
onHideLanguageMenu: function () {
this.log('video_hide_cc_menu', { language: this.getCurrentLanguage() });
this.log('edx.video.language_menu.hidden', { language: this.getCurrentLanguage() });
},
onShowTranscript: function () {

2
common/lib/xmodule/xmodule/js/src/video/09_video_caption.js
View File

@@ -398,7 +398,7 @@
// present instead of on the container hover, since it wraps
// the "CC" and "Transcript" buttons as well.
if ($(event.currentTarget).find('.lang').length) {
this.state.el.trigger('language_menu:show');
this.state.el.trigger('language_menu:hide');
}
},