Andal.LND/edx-platform
6
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Merge pull request #16501 from edx/thallada/ret-fix-highlights-number

Browse Source 
Re-render XBlockOutlineView on highlights change
This commit is contained in:
Gabe Mulley
2017-11-09 10:33:09 -05:00
committed by GitHub
parent 004da0c381 1927551ac6
commit d037a19c94
2 changed files with 6 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

1
cms/static/js/spec/views/pages/course_outline_spec.js
View File

@@ -635,6 +635,7 @@ define(['jquery', 'edx-ui-toolkit/js/utils/spec-helpers/ajax-helpers', 'common/j
saveHighlights();
expectServerHandshakeWithHighlights(updatedHighlights);
expectHighlightLinkNumberToBe(updatedHighlights.length);
openHighlights();
expectHighlightsToBe(updatedHighlights);

6
cms/static/js/views/xblock_outline.js
View File

@@ -224,7 +224,11 @@ define(['jquery', 'underscore', 'gettext', 'js/views/baseview', 'common/js/compo
},
onSync: function(event) {
if (ViewUtils.hasChangedAttributes(this.model, ['visibility_state', 'child_info', 'display_name'])) {
var hasChangedAttributes = ViewUtils.hasChangedAttributes(
this.model,
['visibility_state', 'child_info', 'display_name', 'highlights']
);
if (hasChangedAttributes) {
this.onXBlockChange();
}
},