Andal.LND/edx-platform
6
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

python 3 fixes

Browse Source 
changes made as suggested

minor change

changes made as suggested

test fixes for python 2

removed debug statement

quality fixes

quality fix

quality fix
This commit is contained in:
aarif
2019-09-04 18:04:11 +05:00
parent 7012bcea94
commit cde8a2a62a
2 changed files with 5 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
cms/djangoapps/contentstore/views/tests/test_videos.py
View File

@@ -1182,7 +1182,7 @@ class TranscriptPreferencesTestCase(VideoUploadTestBase, CourseTestCase):
'preferred_languages': ['es', 'ur']
},
True,
u"Invalid languages [u'es', u'ur'].",
"Invalid languages ['es', 'ur'].",
400
),
(
@@ -1211,7 +1211,7 @@ class TranscriptPreferencesTestCase(VideoUploadTestBase, CourseTestCase):
'preferred_languages': ['es', 'ur']
},
True,
u"Invalid languages [u'es', u'ur'].",
"Invalid languages ['es', 'ur'].",
400
),
(
@@ -1222,7 +1222,7 @@ class TranscriptPreferencesTestCase(VideoUploadTestBase, CourseTestCase):
'preferred_languages': ['es', 'ur']
},
True,
u"Invalid languages [u'es', u'ur'].",
"Invalid languages ['es', 'ur'].",
400
),
# Success

5
cms/djangoapps/contentstore/views/videos.py
View File

@@ -271,7 +271,7 @@ def validate_transcript_preferences(provider, cielo24_fidelity, cielo24_turnarou
return error, preferences
if not preferred_languages or not set(preferred_languages) <= set(supported_languages.keys()):
error = u'Invalid languages {}.'.format(preferred_languages)
error = 'Invalid languages {}.'.format(preferred_languages) # pylint: disable=unicode-format-string
return error, preferences
# Validated Cielo24 preferences
@@ -330,7 +330,6 @@ def transcript_preferences_handler(request, course_key_string):
is_video_transcript_enabled = VideoTranscriptEnabledFlag.feature_enabled(course_key)
if not is_video_transcript_enabled:
return HttpResponseNotFound()
if request.method == 'POST':
data = request.json
provider = data.get('provider')
@@ -340,7 +339,7 @@ def transcript_preferences_handler(request, course_key_string):
cielo24_turnaround=data.get('cielo24_turnaround', ''),
three_play_turnaround=data.get('three_play_turnaround', ''),
video_source_language=data.get('video_source_language'),
preferred_languages=data.get('preferred_languages', [])
preferred_languages=list(map(str, data.get('preferred_languages', [])))
)
if error:
response = JsonResponse({'error': error}, status=400)