Andal.LND/edx-platform
6
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Remove unnecessary and misleading data-rel attributes

Browse Source 
These were first added in
https://github.com/edx/edx-platform/commit/d95b46dd19 but they don't
seem to do anything.  On Open edX sites, they are misleading.
This commit is contained in:
Ned Batchelder
2020-12-01 13:54:08 -05:00
parent 156b91d2ef
commit cd0ef5b317
1 changed files with 6 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
cms/templates/widgets/footer.html
View File

@@ -15,28 +15,28 @@ from openedx.core.djangolib.markup import HTML, Text
<div class="footer-content-primary">
<div class="colophon">
<p>&copy; ${datetime.now(pytz.timezone(settings.TIME_ZONE)).year} <a data-rel="edx.org" href="${marketing_link('ROOT')}" rel="external">${settings.PLATFORM_NAME}</a>.</p>
<p>&copy; ${datetime.now(pytz.timezone(settings.TIME_ZONE)).year} <a href="${marketing_link('ROOT')}" rel="external">${settings.PLATFORM_NAME}</a>.</p>
</div>
<nav class="nav-peripheral" aria-label="${_("Policies")}">
<ol>
% if is_marketing_link_set('TOS'):
<li class="nav-item nav-peripheral-tos">
<a data-rel="edx.org" href="${marketing_link('TOS')}">${_("Terms of Service")}</a>
<a href="${marketing_link('TOS')}">${_("Terms of Service")}</a>
</li>
% endif
% if is_marketing_link_set('PRIVACY'):
<li class="nav-item nav-peripheral-pp">
<a data-rel="edx.org" href="${marketing_link('PRIVACY')}">${_("Privacy Policy")}</a>
<a href="${marketing_link('PRIVACY')}">${_("Privacy Policy")}</a>
</li>
% endif
% if waffle().is_enabled(ENABLE_ACCESSIBILITY_POLICY_PAGE):
<li class="nav-item nav-peripheral-aar">
<a data-rel="edx.org" href="${reverse('accessibility')}">${_("Accessibility Accommodation Request")}</a>
<a href="${reverse('accessibility')}">${_("Accessibility Accommodation Request")}</a>
</li>
%endif
<li class="nav-item">
<a data-rel="edx.org" id="lms-link" href="${settings.LMS_ROOT_URL}">${_("LMS")}</a>
<a id="lms-link" href="${settings.LMS_ROOT_URL}">${_("LMS")}</a>
</li>
</ol>
</nav>
@@ -48,7 +48,7 @@ from openedx.core.djangolib.markup import HTML, Text
<p>
## Translators: 'edX' and 'Open edX' are trademarks of 'edX Inc.'. Please do not translate any of these trademarks and company names.
${Text(_("edX, Open edX, and the edX and Open edX logos are registered trademarks of {link_start}edX Inc.{link_end}")).format(
link_start=HTML(u"<a data-rel='edx.org' href='https://www.edx.org/'>"),
link_start=HTML(u"<a href='https://www.edx.org/'>"),
link_end=HTML(u"</a>")
)}
</p>