Merge pull request #17562 from edx/thallada/EDUCATOR-2419

EDUCATOR-2419 No upgrade deadline for professional courses
This commit is contained in:
Tyler Hallada
2018-03-01 13:22:41 -05:00
committed by GitHub
2 changed files with 19 additions and 1 deletions

View File

@@ -1726,7 +1726,7 @@ class CourseEnrollment(models.Model):
log.debug('Schedules: Returning None since dynamic upgrade deadline has already passed.')
return None
if self.verified_mode is None:
if self.verified_mode is None or CourseMode.is_professional_mode(self.verified_mode):
log.debug('Schedules: Returning None for dynamic upgrade deadline since the course does not have a '
'verified mode.')
return None

View File

@@ -179,3 +179,21 @@ class CourseEnrollmentTests(SharedModuleStoreTestCase):
ScheduleFactory(enrollment=enrollment)
self.assertIsNotNone(enrollment.schedule)
self.assertEqual(enrollment.upgrade_deadline, course_upgrade_deadline)
@skip_unless_lms
def test_upgrade_deadline_with_schedule_and_professional_mode(self):
"""
Deadline should be None for courses with professional mode.
Regression test for EDUCATOR-2419.
"""
course = CourseFactory(self_paced=True)
CourseModeFactory(
course_id=course.id,
mode_slug=CourseMode.PROFESSIONAL,
)
enrollment = CourseEnrollmentFactory(course_id=course.id, mode=CourseMode.AUDIT)
DynamicUpgradeDeadlineConfiguration.objects.create(enabled=True)
ScheduleFactory(enrollment=enrollment)
self.assertIsNotNone(enrollment.schedule)
self.assertIsNone(enrollment.upgrade_deadline)