Merge pull request #30811 from open-craft/0x29a/bb6442/remove_field_data

refactor: remove `field_data` usage by all `DescriptorSystem` subclasses [BD-13]
This commit is contained in:
Piotr Surowiec
2022-09-19 12:35:57 +02:00
committed by GitHub
8 changed files with 7 additions and 9 deletions

View File

@@ -182,7 +182,6 @@ def get_test_descriptor_system(render_template=None):
error_tracker=Mock(name='get_test_descriptor_system.error_tracker'),
render_template=render_template or mock_render_template,
mixins=(InheritanceMixin, XModuleMixin),
field_data=field_data,
services={'field-data': field_data},
)
descriptor_system.get_asides = lambda block: []

View File

@@ -55,7 +55,7 @@ class DummySystem(ImportSystem): # lint-amnesty, pylint: disable=abstract-metho
course_dir=course_dir,
error_tracker=error_tracker,
load_error_modules=load_error_modules,
field_data=KvsFieldData(DictKeyValueStore()),
services={'field-data': KvsFieldData(DictKeyValueStore())},
)

View File

@@ -49,7 +49,7 @@ class DummySystem(ImportSystem): # lint-amnesty, pylint: disable=abstract-metho
error_tracker=error_tracker,
load_error_modules=load_error_modules,
mixins=(InheritanceMixin, XModuleMixin),
field_data=KvsFieldData(DictKeyValueStore()),
services={'field-data': KvsFieldData(DictKeyValueStore())},
)
def render_template(self, _template, _context): # lint-amnesty, pylint: disable=method-hidden

View File

@@ -38,7 +38,7 @@ class InMemorySystem(XMLParsingSystem, MakoDescriptorSystem): # pylint: disable
mixins=xml_import_data.xblock_mixins,
select=xml_import_data.xblock_select,
render_template=lambda template, context: pprint.pformat((template, context)),
field_data=KvsFieldData(DictKeyValueStore()),
services={'field-data': KvsFieldData(DictKeyValueStore())},
)
def process_xml(self, xml): # pylint: disable=method-hidden