Andal.LND/edx-platform
6
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

feat! Dropping Sass support from builtin LTI block (#35769)

Browse Source 
feat!: Dropping Sass support from builtin LTI block

Co-authored by @ttqureshi
This commit is contained in:
M. Tayyab Tahir Qureshi
2024-11-05 17:26:45 +05:00
committed by GitHub
parent 368827af6c
commit b7d08fb61b
4 changed files with 64 additions and 70 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
xmodule/assets/LTIBlockDisplay.scss
View File

@@ -1,3 +0,0 @@
.xmodule_display.xmodule_LTIBlock {
@import "lti/lti.scss";
}

65
xmodule/assets/lti/_lti.scss
View File

@@ -1,65 +0,0 @@
@import 'bourbon/bourbon';
@import 'lms/theme/variables';
@import 'bootstrap/scss/variables';
@import 'lms/theme/variables-v1';
@import 'base/mixins';
h2.problem-header {
display: inline-block;
}
div.problem-progress {
display: inline-block;
padding-left: ($baseline/4);
color: #666;
font-weight: 100;
font-size: em(16);
}
div.lti {
// align center
margin: 0 auto;
.wrapper-lti-link {
@include font-size(14);
background-color: $sidebar-color;
padding: $baseline;
.lti-link {
margin-bottom: 0;
text-align: right;
.link_lti_new_window {
@extend .gray-button;
@include font-size(13);
@include line-height(14);
}
}
}
form.ltiLaunchForm {
display: none;
}
iframe.ltiLaunchFrame {
width: 100%;
height: 800px;
display: block;
border: 0px;
}
h4.problem-feedback-label {
font-weight: 100;
font-size: em(16);
font-family: "Source Sans", "Open Sans", Verdana, Geneva, sans-serif, sans-serif;
}
div.problem-feedback {
margin-top: ($baseline/4);
margin-bottom: ($baseline/4);
}
}

4
xmodule/lti_block.py
View File

@@ -84,7 +84,7 @@ from common.djangoapps.xblock_django.constants import (
)
from xmodule.lti_2_util import LTI20BlockMixin, LTIError
from xmodule.raw_block import EmptyDataRawMixin
from xmodule.util.builtin_assets import add_webpack_js_to_fragment, add_sass_to_fragment
from xmodule.util.builtin_assets import add_webpack_js_to_fragment, add_css_to_fragment
from xmodule.xml_block import XmlMixin
from xmodule.x_module import (
ResourceTemplates,
@@ -524,7 +524,7 @@ class LTIBlock(
"""
fragment = Fragment()
fragment.add_content(self.runtime.service(self, 'mako').render_lms_template('lti.html', self.get_context()))
add_sass_to_fragment(fragment, 'LTIBlockDisplay.scss')
add_css_to_fragment(fragment, 'LTIBlockDisplay.css')
add_webpack_js_to_fragment(fragment, 'LTIBlockDisplay')
shim_xmodule_js(fragment, 'LTI')
return fragment

62
xmodule/static/css-builtin-blocks/LTIBlockDisplay.css Normal file
View File

@@ -0,0 +1,62 @@
@import url("https://fonts.googleapis.com/css?family=Open+Sans:300,400,400i,600,700");
.xmodule_display.xmodule_LTIBlock {
/* stylelint-disable-line */
/* stylelint-disable-line */
/* stylelint-disable-line */
/* stylelint-disable-line */
}
.xmodule_display.xmodule_LTIBlock h2.problem-header {
display: inline-block;
}
.xmodule_display.xmodule_LTIBlock div.problem-progress {
display: inline-block;
padding-left: calc((var(--baseline)/4));
color: #666;
font-weight: 100;
font-size: 1em;
}
.xmodule_display.xmodule_LTIBlock div.lti {
margin: 0 auto;
}
.xmodule_display.xmodule_LTIBlock div.lti .wrapper-lti-link {
font-size: 14px;
background-color: var(--sidebar-color);
padding: var(--baseline);
}
.xmodule_display.xmodule_LTIBlock div.lti .wrapper-lti-link .lti-link {
margin-bottom: 0;
text-align: right;
}
.xmodule_display.xmodule_LTIBlock div.lti .wrapper-lti-link .lti-link .link_lti_new_window {
font-size: 13px;
line-height: 20.72px;
}
.xmodule_display.xmodule_LTIBlock div.lti form.ltiLaunchForm {
display: none;
}
.xmodule_display.xmodule_LTIBlock div.lti iframe.ltiLaunchFrame {
width: 100%;
height: 800px;
display: block;
border: 0px;
}
.xmodule_display.xmodule_LTIBlock div.lti h4.problem-feedback-label {
font-weight: 100;
font-size: 1em;
font-family: "Source Sans", "Open Sans", Verdana, Geneva, sans-serif, sans-serif;
}
.xmodule_display.xmodule_LTIBlock div.lti div.problem-feedback {
margin-top: calc((var(--baseline)/4));
margin-bottom: calc((var(--baseline)/4));
}