Merge pull request #17240 from edx/sofiya/ed-2140

Video completion recording does not happen at the end of the video

common/lib/xmodule/xmodule/assets/vertical/public/js/vertical_student_view.js

@@ -28,7 +28,7 @@ window.VerticalStudentView = function(runtime, element) {
         function(idx, block) {
             var blockKey = block.dataset.id;
 
-            if (block.dataset.completableByViewing === undefined) {
+            if (!block.dataset.completableByViewing) {
                 return;
             }
             // TODO: EDUCATOR-1778

common/lib/xmodule/xmodule/video_module/video_module.py

@@ -438,6 +438,7 @@ class VideoDescriptor(VideoFields, VideoTranscriptsMixin, VideoStudioViewHandler
     module_class = VideoModule
     transcript = module_attr('transcript')
     publish_completion = module_attr('publish_completion')
+    has_custom_completion = module_attr('has_custom_completion')
 
     show_in_read_only_mode = True
 

lms/templates/vert_module.html

@@ -12,7 +12,7 @@
 % for idx, item in enumerate(items):
   <div class="vert vert-${idx}" data-id="${item['id']}" \
     % if item['id'] in watched_completable_blocks:
-      data-completable-by-viewing \
+      data-completable-by-viewing=True \
     % endif
       >
     ${HTML(item['content'])}