Andal.LND/edx-platform
4
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Update ignore rules for aria-current

Browse Source
This commit is contained in:
Farhanah Sheets
2018-12-18 19:41:21 -05:00
committed by Jeff Witt
parent bd1c6fa0c8
commit b1a7235511
12 changed files with 102 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
common/test/acceptance/tests/discussion/test_cohort_management.py
View File

@@ -690,6 +690,11 @@ class CohortConfigurationTest(EventsTestMixin, UniqueCourseTest, CohortTestMixin
"""
Run accessibility audit for cohort management.
"""
self.cohort_management_page.a11y_audit.config.set_rules({
"ignore": [
'aria-valid-attr', #TODO: LEARNER-6611 & LEARNER-6865
]
})
self.cohort_management_page.a11y_audit.check_for_accessibility_errors()

7
common/test/acceptance/tests/discussion/test_discussion.py
View File

@@ -227,6 +227,7 @@ class DiscussionHomePageTest(BaseDiscussionTestCase):
"ignore": [
'section', # TODO: AC-491
'aria-required-children', # TODO: AC-534
'aria-valid-attr', #TODO: LEARNER-6611 & LEARNER-6865
]
})
self.page.a11y_audit.check_for_accessibility_errors()
@@ -464,6 +465,7 @@ class DiscussionTabMultipleThreadTest(BaseDiscussionTestCase, BaseDiscussionMixi
"ignore": [
'section', # TODO: AC-491
'aria-required-children', # TODO: AC-534
'aria-valid-attr', #TODO: LEARNER-6611 & LEARNER-6865
]
})
@@ -536,6 +538,7 @@ class DiscussionOpenClosedThreadTest(BaseDiscussionTestCase):
'section', # TODO: AC-491
'aria-required-children', # TODO: AC-534
'color-contrast', # Commented out for now because they reproducibly fail on Jenkins but not locally
'aria-valid-attr', #TODO: LEARNER-6611 & LEARNER-6865
]
})
page.a11y_audit.check_for_accessibility_errors()
@@ -546,6 +549,7 @@ class DiscussionOpenClosedThreadTest(BaseDiscussionTestCase):
'section', # TODO: AC-491
'aria-required-children', # TODO: AC-534
'color-contrast', # Commented out for now because they reproducibly fail on Jenkins but not locally
'aria-valid-attr', #TODO: LEARNER-6611 & LEARNER-6865
]
})
page.a11y_audit.check_for_accessibility_errors()
@@ -839,6 +843,7 @@ class DiscussionResponseEditTest(BaseDiscussionTestCase):
'ignore': [
'section', # TODO: AC-491
'aria-required-children', # TODO: AC-534
'aria-valid-attr', #TODO: LEARNER-6611 & LEARNER-6865
]
})
page.visit()
@@ -940,6 +945,7 @@ class DiscussionCommentEditTest(BaseDiscussionTestCase):
'ignore': [
'section', # TODO: AC-491
'aria-required-children', # TODO: AC-534
'aria-valid-attr', #TODO: LEARNER-6611 & LEARNER-6865
]
})
page.a11y_audit.check_for_accessibility_errors()
@@ -1366,6 +1372,7 @@ class DiscussionSearchAlertTest(UniqueCourseTest):
'ignore': [
'section', # TODO: AC-491
'aria-required-children', # TODO: AC-534
'aria-valid-attr', #TODO: LEARNER-6611 & LEARNER-6865
]
})
self.page.a11y_audit.check_for_accessibility_errors()

5
common/test/acceptance/tests/lms/test_account_settings.py
View File

@@ -565,4 +565,9 @@ class AccountSettingsA11yTest(AccountSettingsTestMixin, AcceptanceTest):
"""
self.log_in_as_unique_user()
self.visit_account_settings_page()
self.account_settings_page.a11y_audit.config.set_rules({
"ignore": [
'aria-valid-attr', #TODO: LEARNER-6611 & LEARNER-6865
]
})
self.account_settings_page.a11y_audit.check_for_accessibility_errors()

5
common/test/acceptance/tests/lms/test_bookmarks.py
View File

@@ -595,6 +595,11 @@ class BookmarksA11yTests(BookmarksTestMixin):
"""
Verify the basic accessibility of the bookmarks page while paginated.
"""
self.bookmarks_page.a11y_audit.config.set_rules({
"ignore": [
'aria-valid-attr', #TODO: LEARNER-6611 & LEARNER-6865
]
})
self.setup_test(num_chapters=11)
self.bookmark_units(num_units=11)
self.bookmarks_page.visit()

18
common/test/acceptance/tests/lms/test_learner_profile.py
View File

@@ -691,7 +691,13 @@ class LearnerProfileA11yTest(LearnerProfileTestMixin, AcceptanceTest):
(user viewing her own public profile).
"""
username, _ = self.log_in_as_unique_user()
profile_page = self.visit_profile_page(username)
profile_page.a11y_audit.config.set_rules({
"ignore": [
'aria-valid-attr', #TODO: LEARNER-6611 & LEARNER-6865
]
})
profile_page.a11y_audit.check_for_accessibility_errors()
profile_page.make_field_editable('language_proficiencies')
@@ -711,7 +717,13 @@ class LearnerProfileA11yTest(LearnerProfileTestMixin, AcceptanceTest):
# only looking at a read-only profile page with a username.
different_username, _ = self.initialize_different_user(privacy=self.PRIVACY_PUBLIC)
self.log_in_as_unique_user()
profile_page = self.visit_profile_page(different_username)
profile_page.a11y_audit.config.set_rules({
"ignore": [
'aria-valid-attr', #TODO: LEARNER-6611 & LEARNER-6865
]
})
profile_page.a11y_audit.check_for_accessibility_errors()
def test_badges_accessibility(self):
@@ -719,8 +731,14 @@ class LearnerProfileA11yTest(LearnerProfileTestMixin, AcceptanceTest):
Test the accessibility of the badge listings and sharing modal.
"""
username = 'testcert'
AutoAuthPage(self.browser, username=username).visit()
profile_page = self.visit_profile_page(username)
profile_page.a11y_audit.config.set_rules({
"ignore": [
'aria-valid-attr', #TODO: LEARNER-6611 & LEARNER-6865
]
})
profile_page.display_accomplishments()
profile_page.a11y_audit.check_for_accessibility_errors()
profile_page.badges[0].display_modal()

20
common/test/acceptance/tests/lms/test_lms.py
View File

@@ -525,12 +525,22 @@ class CourseWikiA11yTest(UniqueCourseTest):
"""
Verify the basic accessibility of the wiki page as initially displayed.
"""
self.course_wiki_page.a11y_audit.config.set_rules({
"ignore": [
'aria-valid-attr', #TODO: LEARNER-6611 & LEARNER-6865
]
})
self.course_wiki_page.a11y_audit.check_for_accessibility_errors()
def test_edit(self):
"""
Verify the basic accessibility of edit wiki page.
"""
self.course_wiki_edit_page.a11y_audit.config.set_rules({
"ignore": [
'aria-valid-attr', #TODO: LEARNER-6611 & LEARNER-6865
]
})
self._open_editor()
self.course_wiki_edit_page.a11y_audit.check_for_accessibility_errors()
@@ -540,6 +550,11 @@ class CourseWikiA11yTest(UniqueCourseTest):
"""
self.course_wiki_page.show_history()
history_page = CourseWikiHistoryPage(self.browser, self.course_id, self.course_info)
history_page.a11y_audit.config.set_rules({
"ignore": [
'aria-valid-attr', #TODO: LEARNER-6611 & LEARNER-6865
]
})
history_page.wait_for_page()
history_page.a11y_audit.check_for_accessibility_errors()
@@ -549,6 +564,11 @@ class CourseWikiA11yTest(UniqueCourseTest):
"""
self.course_wiki_page.show_children()
children_page = CourseWikiChildrenPage(self.browser, self.course_id, self.course_info)
children_page.a11y_audit.config.set_rules({
"ignore": [
'aria-valid-attr', #TODO: LEARNER-6611 & LEARNER-6865
]
})
children_page.wait_for_page()
children_page.a11y_audit.check_for_accessibility_errors()

10
common/test/acceptance/tests/lms/test_lms_course_home.py
View File

@@ -136,6 +136,11 @@ class CourseHomeA11yTest(CourseHomeBaseTest):
"""
course_home_page = CourseHomePage(self.browser, self.course_id)
course_home_page.visit()
course_home_page.a11y_audit.config.set_rules({
"ignore": [
'aria-valid-attr', #TODO: LEARNER-6611 & LEARNER-6865
]
})
course_home_page.a11y_audit.check_for_accessibility_errors()
def test_course_search_a11y(self):
@@ -145,4 +150,9 @@ class CourseHomeA11yTest(CourseHomeBaseTest):
course_home_page = CourseHomePage(self.browser, self.course_id)
course_home_page.visit()
course_search_results_page = course_home_page.search_for_term("Test Search")
course_search_results_page.a11y_audit.config.set_rules({
"ignore": [
'aria-valid-attr', #TODO: LEARNER-6611 & LEARNER-6865
]
})
course_search_results_page.a11y_audit.check_for_accessibility_errors()

5
common/test/acceptance/tests/lms/test_lms_dashboard.py
View File

@@ -409,6 +409,11 @@ class LmsDashboardA11yTest(BaseLmsDashboardTestMultiple):
"""
Test the accessibility of the course listings
"""
self.dashboard_page.a11y_audit.config.set_rules({
"ignore": [
'aria-valid-attr', #TODO: LEARNER-6611 & LEARNER-6865
]
})
course_listings = self.dashboard_page.get_courses()
self.assertEqual(len(course_listings), 3)
self.dashboard_page.a11y_audit.check_for_accessibility_errors()

5
common/test/acceptance/tests/lms/test_lms_instructor_dashboard.py
View File

@@ -77,6 +77,11 @@ class LMSInstructorDashboardA11yTest(BaseInstructorDashboardTest):
self.instructor_dashboard_page = self.visit_instructor_dashboard()
def test_instructor_dashboard_a11y(self):
self.instructor_dashboard_page.a11y_audit.config.set_rules({
"ignore": [
'aria-valid-attr', #TODO: LEARNER-6611 & LEARNER-6865
]
})
self.instructor_dashboard_page.a11y_audit.check_for_accessibility_errors()

15
common/test/acceptance/tests/lms/test_programs.py
View File

@@ -121,6 +121,11 @@ class ProgramListingPageA11yTest(ProgramPageBase):
def test_empty_a11y(self):
"""Test a11y of the page's empty state."""
self.listing_page.a11y_audit.config.set_rules({
"ignore": [
'aria-valid-attr', #TODO: LEARNER-6611 & LEARNER-6865
]
})
self.auth(enroll=False)
self.stub_catalog_api(programs=[self.program], pathways=[])
self.cache_programs()
@@ -133,6 +138,11 @@ class ProgramListingPageA11yTest(ProgramPageBase):
def test_cards_a11y(self):
"""Test a11y when program cards are present."""
self.listing_page.a11y_audit.config.set_rules({
"ignore": [
'aria-valid-attr', #TODO: LEARNER-6611 & LEARNER-6865
]
})
self.auth()
self.stub_catalog_api(programs=[self.program], pathways=[])
self.cache_programs()
@@ -157,6 +167,11 @@ class ProgramDetailsPageA11yTest(ProgramPageBase):
def test_a11y(self):
"""Test the page's a11y compliance."""
self.details_page.a11y_audit.config.set_rules({
"ignore": [
'aria-valid-attr', #TODO: LEARNER-6611 & LEARNER-6865
]
})
self.auth()
self.stub_catalog_api(programs=[self.program], pathways=[])
self.cache_programs()

5
common/test/acceptance/tests/lms/test_progress_page.py
View File

@@ -429,5 +429,10 @@ class ProgressPageA11yTest(ProgressPageBaseTest):
"""
Test the accessibility of the progress page.
"""
self.progress_page.a11y_audit.config.set_rules({
"ignore": [
'aria-valid-attr', #TODO: LEARNER-6611 & LEARNER-6865
]
})
self.progress_page.visit()
self.progress_page.a11y_audit.check_for_accessibility_errors()

3
common/test/acceptance/tests/studio/test_studio_textbooks.py
View File

@@ -79,7 +79,8 @@ class TextbooksTest(StudioCourseTest):
self.textbook_view_page.a11y_audit.config.set_rules({
'ignore': [
'section' # AC-503
'section', # AC-503
'aria-valid-attr', #TODO: LEARNER-6611 & LEARNER-6865
],
})
self.textbook_view_page.a11y_audit.check_for_accessibility_errors()