Andal.LND/edx-platform
6
0
Fork 0
Code Issues Pull Requests Actions 1 Packages Projects Releases Wiki Activity

Better handling of plurals during .po validation

Browse Source 
Now any of the plurals being missing will count as an Empty translation,
and for looking at tags, the two English strings and all the translated
strings are mooshed together.
This commit is contained in:
Ned Batchelder
2014-01-06 15:52:15 -05:00
parent c459633534
commit af120fdf53
1 changed files with 16 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files

24
i18n/tests/test_validate.py
View File

@@ -93,13 +93,21 @@ def check_messages(filename):
problems.append(("Non-BMP char", msg.msgid, msg.msgstr))
if msg.msgid_plural:
# Skip plurals, I don't know how the tags relate.
continue
if not msg.msgstr:
problems.append(("Empty translation", msg.msgid))
# Plurals: two strings in, N strings out.
source = msg.msgid + " | " + msg.msgid_plural
translation = " | ".join(v for k,v in sorted(msg.msgstr_plural.items()))
empty = any(not t.strip() for t in msg.msgstr_plural.values())
else:
id_tags = tags_in_string(msg.msgid)
tx_tags = tags_in_string(msg.msgstr)
# Singular: just one string in and one string out.
source = msg.msgid
translation = msg.msgstr
empty = not msg.msgstr.strip()
if empty:
problems.append(("Empty translation", source))
else:
id_tags = tags_in_string(source)
tx_tags = tags_in_string(translation)
if id_tags != tx_tags:
id_has = u", ".join(u'"{}"'.format(t) for t in id_tags - tx_tags)
tx_has = u", ".join(u'"{}"'.format(t) for t in tx_tags - id_tags)
@@ -111,8 +119,8 @@ def check_messages(filename):
diff = u"{} added".format(tx_has)
problems.append((
"Different tags in source and translation",
msg.msgid,
msg.msgstr,
source,
translation,
diff
))