Andal.LND/edx-platform
6
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

fix: added info in notification preferences (#37295)

Browse Source
This commit is contained in:
Muhammad Adeel Tajamul
2025-08-29 11:41:28 +05:00
committed by GitHub
parent 25522efabc
commit acad883a38
2 changed files with 27 additions and 10 deletions
Download Patch File Download Diff File Expand all files Collapse all files

31
openedx/core/djangoapps/notifications/tests/test_views.py
View File

@@ -30,7 +30,10 @@ from openedx.core.djangoapps.notifications.email.utils import encrypt_string
from openedx.core.djangoapps.notifications.models import (
CourseNotificationPreference, Notification, NotificationPreference
)
from openedx.core.djangoapps.notifications.serializers import add_non_editable_in_preference
from openedx.core.djangoapps.notifications.serializers import (
add_info_to_notification_config,
add_non_editable_in_preference
)
from xmodule.modulestore.tests.django_utils import ModuleStoreTestCase
from xmodule.modulestore.tests.factories import CourseFactory
@@ -711,6 +714,7 @@ class TestNotificationPreferencesView(ModuleStoreTestCase):
expected_data = exclude_inaccessible_preferences(self.default_data['data'], self.user)
expected_data = add_non_editable_in_preference(expected_data)
expected_data = add_info_to_notification_config(expected_data)
self.assertEqual(response.data['data'], expected_data)
@@ -768,25 +772,30 @@ class TestNotificationPreferencesView(ModuleStoreTestCase):
"web": False,
"email": False,
"push": False,
"email_cadence": "Daily"
"email_cadence": "Daily",
"info": ""
},
"new_question_post": {
"web": False,
"email": False,
"push": False,
"email_cadence": "Daily"
"email_cadence": "Daily",
"info": ""
},
"new_instructor_all_learners_post": {
"web": False,
"email": False,
"push": False,
"email_cadence": "Daily"
"email_cadence": "Daily",
"info": ""
},
"core": {
"web": False,
"email": False,
"push": False,
"email_cadence": "Daily"
"email_cadence": "Daily",
"info": "Notifications for responses and comments on your posts, and the ones you’re "
"following, including endorsements to your responses and on your posts."
}
},
"non_editable": {
@@ -803,13 +812,15 @@ class TestNotificationPreferencesView(ModuleStoreTestCase):
"web": False,
"email": False,
"push": False,
"email_cadence": "Daily"
"email_cadence": "Daily",
"info": ""
},
"core": {
"web": True,
"email": True,
"push": True,
"email_cadence": "Daily"
"email_cadence": "Daily",
"info": "Notifications for new announcements and updates from the course team."
}
},
"non_editable": {
@@ -824,13 +835,15 @@ class TestNotificationPreferencesView(ModuleStoreTestCase):
"web": False,
"email": False,
"push": False,
"email_cadence": "Daily"
"email_cadence": "Daily",
"info": ""
},
"core": {
"web": True,
"email": True,
"push": True,
"email_cadence": "Daily"
"email_cadence": "Daily",
"info": "Notifications for submission grading."
}
},
"non_editable": {

6
openedx/core/djangoapps/notifications/views.py
View File

@@ -31,6 +31,7 @@ from .models import Notification
from .serializers import (
NotificationSerializer,
UserNotificationPreferenceUpdateAllSerializer,
add_info_to_notification_config,
add_non_editable_in_preference
)
from .tasks import create_notification_preference
@@ -323,11 +324,14 @@ class NotificationPreferencesView(APIView):
type_details['push'] = user_pref.push
type_details['email_cadence'] = user_pref.email_cadence
exclude_inaccessible_preferences(structured_preferences, request.user)
structured_preferences = add_non_editable_in_preference(
add_info_to_notification_config(structured_preferences)
)
return Response({
'status': 'success',
'message': 'Notification preferences retrieved successfully.',
'show_preferences': get_show_notifications_tray(self.request.user),
'data': add_non_editable_in_preference(structured_preferences)
'data': structured_preferences
}, status=status.HTTP_200_OK)
def put(self, request):