Andal.LND/edx-platform
4
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

fix tests

Browse Source
This commit is contained in:
Robert Raposa
2020-02-25 14:35:18 -05:00
parent 84686e81c3
commit a4716c75cb
4 changed files with 17 additions and 18 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
common/djangoapps/course_modes/api/v1/tests/test_views.py
View File

@@ -80,7 +80,7 @@ class CourseModesViewTestBase(AuthAndScopesTestMixin):
"""
pass
@ddt.data(JWT_AUTH_TYPES)
@ddt.data(*JWT_AUTH_TYPES)
def test_jwt_on_behalf_of_user(self, auth_type):
"""
We have to override this super method due to this API

4
common/djangoapps/third_party_auth/api/tests/test_permissions.py
View File

@@ -184,6 +184,10 @@ class ThirdPartyAuthPermissionTest(TestCase):
)
def _assert_jwt_restricted_case(self, scopes, filters, expected_response):
"""
Asserts the provided scopes and filters result in the expected response
for a restricted JWT.
"""
user = self._create_user()
auth_header = self._create_jwt_header(user, is_restricted=True, scopes=scopes, filters=filters)

11
lms/djangoapps/certificates/apis/v0/tests/test_views.py
View File

@@ -201,8 +201,7 @@ class CertificatesListRestApiTest(AuthAndScopesTestMixin, SharedModuleStoreTestC
)
@patch('edx_rest_framework_extensions.permissions.log')
@ddt.data(*product(list(AuthType)))
@ddt.unpack
@ddt.data(*list(AuthType))
def test_another_user(self, auth_type, mock_log):
"""
Returns 200 with empty list for OAuth, Session, and JWT auth.
@@ -213,8 +212,7 @@ class CertificatesListRestApiTest(AuthAndScopesTestMixin, SharedModuleStoreTestC
self.assertEqual(resp.status_code, status.HTTP_200_OK)
self.assertEqual(len(resp.data), 0)
@ddt.data(*product(list(AuthType)))
@ddt.unpack
@ddt.data(*list(AuthType))
def test_another_user_with_certs_shared_public(self, auth_type):
"""
Returns 200 with cert list for OAuth, Session, and JWT auth.
@@ -233,8 +231,7 @@ class CertificatesListRestApiTest(AuthAndScopesTestMixin, SharedModuleStoreTestC
self.assertEqual(resp.status_code, status.HTTP_200_OK)
self.assertEqual(len(resp.data), 1)
@ddt.data(*product(list(AuthType)))
@ddt.unpack
@ddt.data(*list(AuthType))
def test_another_user_with_certs_shared_custom(self, auth_type):
"""
Returns 200 with cert list for OAuth, Session, and JWT auth.
@@ -259,7 +256,7 @@ class CertificatesListRestApiTest(AuthAndScopesTestMixin, SharedModuleStoreTestC
self.assertEqual(len(resp.data), 1)
@patch('edx_rest_framework_extensions.permissions.log')
@ddt.data(JWT_AUTH_TYPES)
@ddt.data(*JWT_AUTH_TYPES)
def test_jwt_on_behalf_of_other_user(self, auth_type, mock_log):
""" Returns 403 when scopes are enforced with JwtHasUserFilterForRequestedUser. """
jwt_token = self._create_jwt_token(self.other_student, auth_type, include_me_filter=True)

18
openedx/core/djangoapps/user_authn/tests/utils.py
View File

@@ -3,7 +3,6 @@
from datetime import datetime, timedelta
from enum import Enum
from itertools import product
import ddt
import pytz
@@ -142,19 +141,19 @@ class AuthAndScopesTestMixin(object):
resp = self.client.get(self.get_url(self.student.username))
self.assertEqual(resp.status_code, status.HTTP_401_UNAUTHORIZED)
@ddt.data(JWT_AUTH_TYPES)
@ddt.data(*JWT_AUTH_TYPES)
def test_self_user(self, auth_type):
resp = self.get_response(auth_type)
self.assertEqual(resp.status_code, status.HTTP_200_OK)
self.assert_success_response_for_student(resp)
@ddt.data(list(AuthType))
@ddt.data(*list(AuthType))
def test_staff_user(self, auth_type):
resp = self.get_response(auth_type, requesting_user=self.global_staff)
self.assertEqual(resp.status_code, status.HTTP_200_OK)
self.assert_success_response_for_student(resp)
@ddt.data(list(AuthType))
@ddt.data(*list(AuthType))
def test_inactive_user(self, auth_type):
self.student.is_active = False
self.student.save()
@@ -162,8 +161,7 @@ class AuthAndScopesTestMixin(object):
self.assertEqual(resp.status_code, status.HTTP_200_OK)
@patch('edx_rest_framework_extensions.permissions.log')
@ddt.data(list(AuthType))
@ddt.unpack
@ddt.data(*list(AuthType))
def test_another_user(self, auth_type, mock_log):
"""
Returns 403 for OAuth, Session, and JWT auth with IsUserInUrl.
@@ -182,7 +180,7 @@ class AuthAndScopesTestMixin(object):
self._assert_in_log("IsUserInUrl", mock_log.info)
@patch('edx_rest_framework_extensions.permissions.log')
@ddt.data(JWT_AUTH_TYPES)
@ddt.data(*JWT_AUTH_TYPES)
def test_jwt_no_scopes(self, auth_type, mock_log):
""" Returns 403 when scopes are enforced with JwtHasScope. """
jwt_token = self._create_jwt_token(self.student, auth_type, scopes=[])
@@ -195,7 +193,7 @@ class AuthAndScopesTestMixin(object):
self._assert_in_log("JwtHasScope", mock_log.warning)
@patch('edx_rest_framework_extensions.permissions.log')
@ddt.data(JWT_AUTH_TYPES)
@ddt.data(*JWT_AUTH_TYPES)
def test_jwt_no_filter(self, auth_type, mock_log):
""" Returns 403 when scopes are enforced with JwtHasContentOrgFilterForRequestedCourse. """
jwt_token = self._create_jwt_token(self.student, auth_type, include_org_filter=False)
@@ -207,7 +205,7 @@ class AuthAndScopesTestMixin(object):
if is_enforced:
self._assert_in_log("JwtHasContentOrgFilterForRequestedCourse", mock_log.warning)
@ddt.data(JWT_AUTH_TYPES)
@ddt.data(*JWT_AUTH_TYPES)
def test_jwt_on_behalf_of_user(self, auth_type):
jwt_token = self._create_jwt_token(self.student, auth_type, include_me_filter=True)
@@ -215,7 +213,7 @@ class AuthAndScopesTestMixin(object):
self.assertEqual(resp.status_code, status.HTTP_200_OK)
@patch('edx_rest_framework_extensions.permissions.log')
@ddt.data(JWT_AUTH_TYPES)
@ddt.data(*JWT_AUTH_TYPES)
def test_jwt_on_behalf_of_other_user(self, auth_type, mock_log):
""" Returns 403 when scopes are enforced with JwtHasUserFilterForRequestedUser. """
jwt_token = self._create_jwt_token(self.other_student, auth_type, include_me_filter=True)