Merge pull request #31060 from shahbaz-arbisoft/shahbaz/VAN-1091

fix: use timeout from settings
This commit is contained in:
Shahbaz Shabbir
2022-10-04 15:57:14 +05:00
committed by GitHub
2 changed files with 4 additions and 1 deletions

View File

@@ -6,6 +6,7 @@ import hashlib
import logging
import requests
from django.conf import settings
from requests.exceptions import ReadTimeout
from rest_framework.status import HTTP_408_REQUEST_TIMEOUT
@@ -58,7 +59,8 @@ class PwnedPasswordsAPI:
if ENABLE_PWNED_PASSWORD_API.is_enabled():
try:
response = requests.get(range_url, timeout=5)
timeout = getattr(settings, 'PASSWORD_POLICY_COMPLIANCE_API_TIMEOUT', 5)
response = requests.get(range_url, timeout=timeout)
entries = dict(map(convert_password_tuple, response.text.split("\r\n")))
return entries

View File

@@ -35,3 +35,4 @@ def plugin_settings(settings):
# Ex: 2018-04-19 00:00:00+00:00
'GENERAL_USER_COMPLIANCE_DEADLINE': None,
}
settings.PASSWORD_POLICY_COMPLIANCE_API_TIMEOUT = 5