Andal.LND/edx-platform
6
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Merge pull request #15020 from edx/efischer/partition_scheming

Browse Source 
EDUCATOR-199 Fix ICRV broken courses
This commit is contained in:
Eric Fischer
2017-05-04 09:37:53 -04:00
committed by GitHub
parent be3e603e35 f3da0eb5de
commit a047d009c7
2 changed files with 19 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

21
openedx/core/djangoapps/user_api/partition_schemes.py
View File

@@ -17,11 +17,26 @@ class NotImplementedPartitionScheme(object):
"""
@classmethod
def get_group_for_user(cls, course_key, user, user_partition, assign=True, track_function=None):
def get_group_for_user(cls, course_key, user, user_partition, assign=True, track_function=None): # pylint: disable=unused-argument
"""
Dummy method, will fail hard if anyone tries to use this scheme.
Returning None is equivalent to saying "This user is not in any groups
using this partition scheme", be sure the scheme you're removing is
compatible with that assumption.
"""
raise NotImplementedError()
return None
class ReturnGroup1PartitionScheme(object):
"""
This scheme is needed to allow verification partitions to be killed, see EDUCATOR-199
"""
@classmethod
def get_group_for_user(cls, course_key, user, user_partition, assign=True, track_function=None): # pylint: disable=unused-argument
"""
The previous "allow" definition for verification was defined as 1, so return that.
Details at https://github.com/edx/edx-platform/pull/14913/files#diff-feff1466ec4d1b8c38894310d8342a80
"""
return user_partition.get_group(1)
class RandomUserPartitionScheme(object):

2
setup.py
View File

@@ -41,7 +41,7 @@ setup(
"openedx.user_partition_scheme": [
"random = openedx.core.djangoapps.user_api.partition_schemes:RandomUserPartitionScheme",
"cohort = openedx.core.djangoapps.course_groups.partition_scheme:CohortPartitionScheme",
"verification = openedx.core.djangoapps.user_api.partition_schemes:NotImplementedPartitionScheme",
"verification = openedx.core.djangoapps.user_api.partition_schemes:ReturnGroup1PartitionScheme",
"enrollment_track = openedx.core.djangoapps.verified_track_content.partition_scheme:EnrollmentTrackPartitionScheme",
],
"openedx.block_structure_transformer": [