Andal.LND/edx-platform
6
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

extract tracking_id logic into a method

Browse Source
This commit is contained in:
Gabe Mulley
2017-11-15 12:56:14 -05:00
parent 46c7327211
commit a031bf9587
1 changed files with 7 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

11
openedx/core/djangoapps/schedules/tracking.py
View File

@@ -87,10 +87,7 @@ class GoogleAnalyticsTrackingPixel(object):
parameter_name = attribute.metadata['param_name']
parameters[parameter_name] = str(value)
tracking_id = get_config_value_from_site_or_settings("GOOGLE_ANALYTICS_ACCOUNT", site=self.site)
if tracking_id is None:
tracking_id = get_config_value_from_site_or_settings("GOOGLE_ANALYTICS_TRACKING_ID", site=self.site)
tracking_id = self._get_tracking_id()
if tracking_id is None:
return None
@@ -106,3 +103,9 @@ class GoogleAnalyticsTrackingPixel(object):
parameters[param_name] = unicode(self.course_id)
return u"https://www.google-analytics.com/collect?{params}".format(params=urlencode(parameters))
def _get_tracking_id(self):
tracking_id = get_config_value_from_site_or_settings("GOOGLE_ANALYTICS_ACCOUNT", site=self.site)
if tracking_id is None:
tracking_id = get_config_value_from_site_or_settings("GOOGLE_ANALYTICS_TRACKING_ID", site=self.site)
return tracking_id