address feedback

This commit is contained in:
Qubad786
2017-05-04 21:31:08 +05:00
parent 657249bd6d
commit 9db1b9cc1b

View File

@@ -226,11 +226,22 @@ class CourseOverview(TimeStampedModel):
])
CourseOverviewImageSet.create_or_update(course_overview, course)
except IntegrityError:
# There is a rare race condition that will occur if
# CourseOverview.get_from_id is called while a
# another identical overview is already in the process
# of being created.
# One of the overviews will be saved normally, while the
# other one will cause an IntegrityError because it tries
# to save a duplicate.
# (see: https://openedx.atlassian.net/browse/TNL-2854).
pass
except Exception: # pylint: disable=broad-except
log.exception(
"CourseOverview for course %s failed!",
course_id,
)
raise
return course_overview
elif course is not None: