Andal.LND/edx-platform
4
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Remove empty signatories from certificate.

Browse Source 
Empty signatories are shown as broken images on the certs which is
affecting user experience.To improve it, empty signatories are
filtered before rendering the cert.

PROD-319
This commit is contained in:
uzairr
2019-08-21 15:41:53 +05:00
parent acf3cb684d
commit 97a468fa86
1 changed files with 10 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files

18
lms/templates/certificates/_accomplishment-rendering.html
View File

@@ -46,15 +46,17 @@ course_mode_class = course_mode if course_mode else ''
<div class="list-signatories">
% if certificate_data:
% for signatory in certificate_data.get('signatories', []):
<div class="signatory">
<img class="signatory-signature" src="${static.url(signatory['signature_image_path'])}" alt="${signatory['name']}">
% if signatory.get('signature_image_path'):
<div class="signatory">
<img class="signatory-signature" src="${static.url(signatory['signature_image_path'])}" alt="${signatory['name']}">
<h4 class="signatory-name hd-5">${signatory['name']}</h4>
<p class="signatory-credentials copy copy-micro">
<span class="role">${signatory['title']}</span>
<span class="organization">${signatory['organization']}</span>
</p>
</div>
<h4 class="signatory-name hd-5">${signatory['name']}</h4>
<p class="signatory-credentials copy copy-micro">
<span class="role">${signatory['title']}</span>
<span class="organization">${signatory['organization']}</span>
</p>
</div>
% endif
% endfor
% endif
</div>