Andal.LND/edx-platform
4
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Merge pull request #16175 from edx/robrap/LEARNER-2026-clean-up

Browse Source 
LEARNER-2026: Revert remains of 'upgrade upsell to course info banner'.
This commit is contained in:
Robert Raposa
2017-10-06 10:02:49 -04:00
committed by GitHub
parent b96f646d35 e8945ebdc5
commit 91bf523920
8 changed files with 13 additions and 78 deletions
Download Patch File Download Diff File Expand all files Collapse all files

9
openedx/features/course_experience/static/course_experience/js/CourseHome.js
View File

@@ -96,7 +96,7 @@ export class CourseHome { // eslint-disable-line import/prefer-default-export
const $vcDismissToggle = $('.vc-toggle', $vcMessage);
const logEventProperties = { courseRunKey: this.courseRunKey };
Logger.log('edx.course.upgrade.hero.displayed', logEventProperties);
Logger.log('edx.bi.course.upgrade.hero.displayed', logEventProperties);
// Get height of container and button
let vcHeight = $vcMessage.outerHeight();
@@ -125,7 +125,7 @@ export class CourseHome { // eslint-disable-line import/prefer-default-export
$vcDismissToggle.click(() => {
if ($vcMessage.hasClass('polite')) {
// Expand message
Logger.log('edx.course.upgrade.hero.expanded', logEventProperties);
Logger.log('edx.bi.course.upgrade.hero.expanded', logEventProperties);
this.persistUpgradeMessageState(false);
$('.vc-fade').fadeOut(400);
@@ -136,14 +136,15 @@ export class CourseHome { // eslint-disable-line import/prefer-default-export
});
} else {
// Collapse message
Logger.log('edx.course.upgrade.hero.collapsed', logEventProperties);
Logger.log('edx.bi.course.upgrade.hero.collapsed', logEventProperties);
this.persistUpgradeMessageState(true);
collapseMessage();
}
});
$('.btn-upgrade', $vcMessage).click(() => {
Logger.log('edx.course.upgrade.hero.clicked', logEventProperties);
Logger.log('edx.bi.course.upgrade.hero.clicked', logEventProperties);
Logger.log('edx.course.enrollment.upgrade.clicked', { location: 'hero' });
});
}
}

5
openedx/features/course_experience/static/course_experience/js/spec/CourseHome_spec.js
View File

@@ -57,13 +57,14 @@ describe('Course Home factory', () => {
it('should send events to Segment and edX on initial load', () => {
expect(window.analytics.track).toHaveBeenCalledWith('Promotion Viewed', segmentEventProperties);
expect(Logger.log).toHaveBeenCalledWith('edx.course.upgrade.hero.displayed', { courseRunKey: runKey });
expect(Logger.log).toHaveBeenCalledWith('edx.bi.course.upgrade.hero.displayed', { courseRunKey: runKey });
});
it('should send events to Segment and edX after clicking the upgrade button ', () => {
$('.vc-message .btn-upgrade').click();
expect(window.analytics.track).toHaveBeenCalledWith('Promotion Viewed', segmentEventProperties);
expect(Logger.log).toHaveBeenCalledWith('edx.course.upgrade.hero.clicked', { courseRunKey: runKey });
expect(Logger.log).toHaveBeenCalledWith('edx.bi.course.upgrade.hero.clicked', { courseRunKey: runKey });
expect(Logger.log).toHaveBeenCalledWith('edx.course.enrollment.upgrade.clicked', { location: 'hero' });
});
});