Correctly point to MAX_LENGTH instead of MIN_LENGTH.
Bug introduced in recent commit.
This commit is contained in:
@@ -14,6 +14,7 @@ from pytz import UTC
|
||||
import analytics
|
||||
|
||||
from eventtracking import tracker
|
||||
from ..accounts import NAME_MIN_LENGTH
|
||||
from ..accounts.views import AccountView
|
||||
from ..models import User, UserPreference, UserOrgTag
|
||||
from ..helpers import intercept_errors
|
||||
@@ -36,6 +37,10 @@ class ProfileInternalError(Exception):
|
||||
pass
|
||||
|
||||
|
||||
FULL_NAME_MAX_LENGTH = 255
|
||||
FULL_NAME_MIN_LENGTH = NAME_MIN_LENGTH
|
||||
|
||||
|
||||
@intercept_errors(ProfileInternalError, ignore_errors=[ProfileRequestError])
|
||||
def preference_info(username):
|
||||
"""Retrieve information about a user's preferences.
|
||||
|
||||
@@ -28,7 +28,6 @@ from ..api import account as account_api, profile as profile_api
|
||||
from ..models import UserOrgTag
|
||||
from ..tests.factories import UserPreferenceFactory
|
||||
from ..tests.test_constants import SORTED_COUNTRIES
|
||||
from openedx.core.djangoapps.user_api.accounts import NAME_MIN_LENGTH
|
||||
|
||||
|
||||
TEST_API_KEY = "test_api_key"
|
||||
@@ -842,7 +841,7 @@ class RegistrationViewTest(ApiTestCase):
|
||||
u"label": u"Full name",
|
||||
u"instructions": u"The name that will appear on your certificates",
|
||||
u"restrictions": {
|
||||
"max_length": NAME_MIN_LENGTH,
|
||||
"max_length": profile_api.FULL_NAME_MAX_LENGTH,
|
||||
},
|
||||
}
|
||||
)
|
||||
@@ -922,7 +921,7 @@ class RegistrationViewTest(ApiTestCase):
|
||||
u"label": u"Full name",
|
||||
u"instructions": u"The name that will appear on your certificates",
|
||||
u"restrictions": {
|
||||
"max_length": NAME_MIN_LENGTH
|
||||
"max_length": profile_api.FULL_NAME_MAX_LENGTH,
|
||||
}
|
||||
}
|
||||
)
|
||||
|
||||
@@ -33,8 +33,6 @@ from .helpers import FormDescription, shim_student_view, require_post_params
|
||||
from .models import UserPreference, UserProfile
|
||||
from .serializers import UserSerializer, UserPreferenceSerializer
|
||||
|
||||
from openedx.core.djangoapps.user_api.accounts import NAME_MIN_LENGTH
|
||||
|
||||
|
||||
class LoginSessionView(APIView):
|
||||
"""HTTP end-points for logging in users. """
|
||||
@@ -352,7 +350,7 @@ class RegistrationView(APIView):
|
||||
label=name_label,
|
||||
instructions=name_instructions,
|
||||
restrictions={
|
||||
"max_length": NAME_MIN_LENGTH,
|
||||
"max_length": profile_api.FULL_NAME_MAX_LENGTH,
|
||||
},
|
||||
required=required
|
||||
)
|
||||
|
||||
Reference in New Issue
Block a user