Andal.LND/edx-platform
6
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Merge pull request #16524 from edx/efischer/revert_library

Browse Source 
Revert "Merge pull request #16447 from appsembler/omar/hide-library-b…
This commit is contained in:
Eric Fischer
2017-11-09 15:00:11 -05:00
committed by GitHub
parent e71f64dc28 7696727fda
commit 801a948d71
2 changed files with 1 additions and 11 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
cms/djangoapps/contentstore/views/library.py
View File

@@ -58,7 +58,7 @@ def get_library_creator_status(user):
elif settings.FEATURES.get('ENABLE_CREATOR_GROUP', False):
return get_course_creator_status(user) == 'granted'
else:
return not settings.FEATURES.get('DISABLE_COURSE_CREATION', False)
return True
@login_required

10
cms/djangoapps/contentstore/views/tests/test_library.py
View File

@@ -28,7 +28,6 @@ def make_url_for_lib(key):
@ddt.ddt
@mock.patch.dict('django.conf.settings.FEATURES', {'DISABLE_COURSE_CREATION': False})
class UnitTestLibraries(CourseTestCase):
"""
Unit tests for library views
@@ -64,15 +63,6 @@ class UnitTestLibraries(CourseTestCase):
_, nostaff_user = self.create_non_staff_authed_user_client()
self.assertEqual(get_library_creator_status(nostaff_user), True)
@mock.patch.dict('django.conf.settings.FEATURES', {'DISABLE_COURSE_CREATION': True})
@mock.patch("contentstore.views.library.LIBRARIES_ENABLED", True)
def test_library_creator_status_with_no_course_creator_role_and_disabled_nonstaff_course_creation(self):
"""
Ensure that `DISABLE_COURSE_CREATION` feature works with libraries as well.
"""
_, nostaff_user = self.create_non_staff_authed_user_client()
self.assertFalse(get_library_creator_status(nostaff_user))
@patch("contentstore.views.library.LIBRARIES_ENABLED", False)
def test_with_libraries_disabled(self):
"""