Revert "Bucket users regardless of enrollment in courseware MFE experiment" (#24700)

This reverts commit 06e04eff8c.

Omitting the course_key argument to ExperimentWaffleFlag.is_enabled
causes a 500 when the underlying experiment flag is enabled.

TNL-7405
This commit is contained in:
Kyle McCormick
2020-08-05 16:28:34 -04:00
committed by GitHub
parent f621c45f24
commit 7e51232205
2 changed files with 3 additions and 3 deletions

View File

@@ -59,7 +59,7 @@ def create_course_enrollment_celebration(sender, instance, created, **kwargs):
# The UI for celebrations is only supported on the MFE right now, so don't turn on
# celebrations unless this enrollment's course is MFE-enabled.
if not REDIRECT_TO_COURSEWARE_MICROFRONTEND.is_enabled():
if not REDIRECT_TO_COURSEWARE_MICROFRONTEND.is_enabled(instance.course_id):
return
try:

View File

@@ -198,7 +198,7 @@ class CoursewareIndex(View):
if getattr(self.section, 'is_time_limited', False):
return
# ALLOW: when flag set for course
if REDIRECT_TO_COURSEWARE_MICROFRONTEND.is_enabled():
if REDIRECT_TO_COURSEWARE_MICROFRONTEND.is_enabled(self.course_key):
raise Redirect(self.microfrontend_url)
@property
@@ -654,7 +654,7 @@ def show_courseware_mfe_link(user, staff_access, course_key):
# course team preview CourseWaffleFlag for this course *or* if we've turned
# on the redirect for your students.
mfe_enabled_for_course_team = COURSEWARE_MICROFRONTEND_COURSE_TEAM_PREVIEW.is_enabled(course_key)
mfe_experiment_enabled_for_course = REDIRECT_TO_COURSEWARE_MICROFRONTEND.is_experiment_on()
mfe_experiment_enabled_for_course = REDIRECT_TO_COURSEWARE_MICROFRONTEND.is_experiment_on(course_key)
if staff_access and (mfe_enabled_for_course_team or mfe_experiment_enabled_for_course):
return True