Merge pull request #3438 from edx/sarina/fix-video-i18n

Don't scrape unnecessary strings for i18n

common/lib/xmodule/xmodule/video_module/video_xfields.py

@@ -7,6 +7,9 @@ from xblock.fields import Scope, String, Float, Boolean, List, Dict
 
 from xmodule.fields import RelativeTime
 
+# Make '_' a no-op so we can scrape strings
+_ = lambda text: text
+
 
 class VideoFields(object):
     """Fields for `VideoModule` and `VideoDescriptor`."""
@@ -121,8 +124,9 @@ class VideoFields(object):
         help="Transcript file format to download by user.",
         scope=Scope.preferences,
         values=[
-            {"display_name": "SubRip (.srt) file", "value": "srt"},
-            {"display_name": "Text (.txt) file", "value": "txt"}
+            # Translators: This is a type of file used for captioning in the video player.
+            {"display_name": _("SubRip (.srt) file"), "value": "srt"},
+            {"display_name": _("Text (.txt) file"), "value": "txt"}
         ],
         default='srt',
     )

lms/templates/video.html

@@ -125,8 +125,8 @@
                   % else:
                   <li class="a11y-menu-item">
                   % endif
-                      <a class="a11y-menu-item-link" href="#${item['value']}" title="${_('{file_format}'.format(file_format=item['display_name']))}" data-value="${item['value']}">
-                        ${_('{file_format}'.format(file_format=item['display_name']))}
+                      <a class="a11y-menu-item-link" href="#${item['value']}" title="${_(item['display_name'])}" data-value="${item['value']}">
+                        ${_(item['display_name'])}
                       </a>
                   </li>
                 % endfor