Andal.LND/edx-platform
6
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

refactor: AA-692: Update location of is-hidden class when fa icon is used

Browse Source 
We ran into a bug where the is-hidden class was being overridden by the
font awesome styling due to a late load of font awesome (causing the
fa class to take precedence). This changes to instead wrap the icon in
the span so there is no competing between the two classes on the same
element
This commit is contained in:
Dillon Dumesnil
2021-03-17 09:30:33 -07:00
parent 9aefd6f986
commit 7791f15509
1 changed files with 10 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

16
lms/templates/seq_module.html
View File

@@ -62,16 +62,20 @@
id="tab_${idx}">
<span class="icon fa seq_${item['type']}" aria-hidden="true"></span>
% if 'complete' in item:
<span
class="fa fa-check-circle check-circle ${"is-hidden" if not item['complete'] else ""}"
style="color:green"
aria-hidden="true"
></span>
<span class="check-circle ${"is-hidden" if not item['complete'] else ""}">
<span
class="fa fa-check-circle"
style="color:green"
aria-hidden="true"
></span>
</span>
% if item['complete']:
<span class="sr">${_("Completed")}</span>
%endif
% endif
<span class="fa fa-fw fa-bookmark bookmark-icon ${"is-hidden" if not item['bookmarked'] else "bookmarked"}" aria-hidden="true"></span>
<span class="bookmark-icon ${"is-hidden" if not item['bookmarked'] else "bookmarked"}">
<span class="fa fa-fw fa-bookmark" aria-hidden="true"></span>
</span>
<div class="sequence-tooltip sr"><span class="sr">${item['type']}&nbsp;</span>${item['page_title']}<span class="sr bookmark-icon-sr">&nbsp;${_("Bookmarked") if item['bookmarked'] else ""}</span></div>
</button>
</li>