Andal.LND/edx-platform
6
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Fix gettext guidance violation

Browse Source 
1. No string concatenation should be used in the gettext function.
2. Some extra parentheses should be used in coffee script, to avoid the following situation: in coffee script, the call ```gettext "text to be extracted" + "text should not be extracted"``` will be translated into ```gettext("text to be extracted" + "text should not be extracted")``` rather than ```gettext("text to be extracted") + "text should not be extracted"```.
This commit is contained in:
louyihua
2015-11-07 13:34:59 +08:00
parent 625b859c21
commit 73d8f06499
2 changed files with 5 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
common/lib/xmodule/xmodule/js/src/combinedopenended/display.coffee
View File

@@ -325,7 +325,7 @@ class @CombinedOpenEnded
@submit_button.hide()
@queueing()
@grader_status = @$(@grader_status_sel)
@grader_status.html("<span class='grading'>" + gettext "Your response has been submitted. Please check back later for your grade." + "</span>")
@grader_status.html("<span class='grading'>" + (gettext "Your response has been submitted. Please check back later for your grade.") + "</span>")
else if @child_type == "selfassessment"
@setup_score_selection()
else if @child_state == 'post_assessment'

8
lms/static/js/student_account/views/account_settings_fields.js
View File

@@ -11,8 +11,8 @@
successMessage: function() {
return this.indicators.success + interpolate_text(
gettext(
'We\'ve sent a confirmation message to {new_email_address}. ' +
'Click the link in the message to update your email address.'
/* jshint maxlen: false */
'We\'ve sent a confirmation message to {new_email_address}. Click the link in the message to update your email address.'
),
{'new_email_address': this.fieldValue()}
);
@@ -79,8 +79,8 @@
successMessage: function () {
return this.indicators.success + interpolate_text(
gettext(
'We\'ve sent a message to {email_address}. ' +
'Click the link in the message to reset your password.'
/* jshint maxlen: false */
'We\'ve sent a message to {email_address}. Click the link in the message to reset your password.'
),
{'email_address': this.model.get(this.options.emailAttribute)}
);