Andal.LND/edx-platform
6
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Rewrote Jasmine tests for slider range to reuse function. More compact and concise.

Browse Source
This commit is contained in:
Valera Rozuvan
2013-10-22 15:00:13 +03:00
parent 159099541a
commit 723772abd0
1 changed files with 43 additions and 59 deletions
Download Patch File Download Diff File Expand all files Collapse all files

102
common/lib/xmodule/xmodule/js/spec/video/general_spec.js
View File

@@ -185,75 +185,59 @@
});
describe('checking start and end times', function () {
var miniTestSuite = [
{
itDescription: 'both times are proper',
data: {start: 12, end: 24},
expectData: {start: 12, end: 24}
},
{
itDescription: 'start time is invalid',
data: {start: '', end: 24},
expectData: {start: 0, end: 24}
},
{
itDescription: 'end time is invalid',
data: {start: 12, end: ''},
expectData: {start: 12, end: null}
},
{
itDescription: 'start time is less than 0',
data: {start: -12, end: 24},
expectData: {start: 0, end: 24}
},
{
itDescription: 'start time is greater than end time',
data: {start: 42, end: 24},
expectData: {start: 42, end: null}
},
];
beforeEach(function () {
loadFixtures('video.html');
});
it('both times are proper', function () {
$('#example').find('.video')
.data({
'start': 12,
'end': 24
});
state = new Video('#example');
expect(state.config.start).toBe(12);
expect(state.config.end).toBe(24);
$.each(miniTestSuite, function (index, test) {
itFabrique(test.itDescription, test.data, test.expectData);
});
it('start time is invalid', function () {
$('#example').find('.video')
.data({
'start': '',
'end': 24
});
return;
state = new Video('#example');
function itFabrique(itDescription, data, expectData) {
it(itDescription, function () {
$('#example').find('.video')
.data({
'start': data.start,
'end': data.end
});
expect(state.config.start).toBe(0);
expect(state.config.end).toBe(24);
});
state = new Video('#example');
it('end time is invalid', function () {
$('#example').find('.video')
.data({
'start': 12,
'end': ''
});
state = new Video('#example');
expect(state.config.start).toBe(12);
expect(state.config.end).toBe(null);
});
it('start time is less than 0', function () {
$('#example').find('.video')
.data({
'start': -12,
'end': 24
});
state = new Video('#example');
expect(state.config.start).toBe(0);
expect(state.config.end).toBe(24);
});
it('start time is greater than end time', function () {
$('#example').find('.video')
.data({
'start': 42,
'end': 24
});
state = new Video('#example');
expect(state.config.start).toBe(42);
expect(state.config.end).toBe(null);
});
expect(state.config.start).toBe(expectData.start);
expect(state.config.end).toBe(expectData.end);
});
}
});
describe('multiple YT on page', function () {