Don't count a non-existing forums user as a failure

This commit is contained in:
Matt Tuchfarber
2019-03-14 11:15:25 -04:00
parent 5a164df3b7
commit 634866dd0c

View File

@@ -658,12 +658,20 @@ class ReplaceUsernamesView(APIView):
)
return True
except comment_client.CommentClientRequestError as exc:
log.exception(
u"Unable to change username from %s to %s in forums because forums API call failed with: %s.",
current_username,
new_username,
exc,
)
if exc.status_code == 404:
log.info(
u"Unable to change username from %s to %s in forums because user doesn't exist in forums",
current_username,
new_username,
)
return True
else:
log.exception(
u"Unable to change username from %s to %s in forums because forums API call failed with: %s.",
current_username,
new_username,
exc,
)
return False
log.info(