Andal.LND/edx-platform
6
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Merge pull request #8668 from edx/peter-fogg/update-team-tab-urls

Browse Source 
Update URL when switching between Team tabs.
This commit is contained in:
Peter Fogg
2015-06-25 09:19:11 -04:00
parent 4662246bf3 e6c7a571d1
commit 5ca6bfeb70
2 changed files with 8 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
lms/static/js/components/tabbed/views/tabbed_view.js
View File

@@ -41,12 +41,14 @@
},
setActiveTab: function (index) {
var tab = this.tabs[index],
view = tab.view;
this.$('a.is-active').removeClass('is-active').attr('aria-selected', 'false');
this.$('a[data-index='+index+']').addClass('is-active').attr('aria-selected', 'true');
var view = this.tabs[index].view;
view.render();
this.$('.page-content-main').html(view.$el.html());
this.$('.sr-is-focusable').focus();
this.router.navigate(tab.url, {replace: true});
},
switchTab: function (event) {

5
lms/static/js/spec/components/tabbed/tabbed_view_spec.js
View File

@@ -72,6 +72,11 @@
expect(view.$('.nav-item[data-index=0]')).toHaveAttr('aria-selected', 'false');
expect(view.$('.nav-item[data-index=1]')).toHaveAttr('aria-selected', 'true');
});
it('updates the page URL on tab switches without adding to browser history', function () {
view.$('.nav-item[data-index=1]').click();
expect(Backbone.history.navigate).toHaveBeenCalledWith('test 2', {replace: true});
});
});
}
);