Andal.LND/edx-platform
6
0
Fork 0
Code Issues Pull Requests Actions 1 Packages Projects Releases Wiki Activity

Merge pull request #10465 from edx/peter-fogg/fix-spec-helpers-closure

Browse Source 
Fix `withData` and `withConfiguration` helpers.
This commit is contained in:
Peter Fogg
2015-11-04 10:21:30 -05:00
parent b48b2b645f 759a3c4f1f
commit 5bd6e829e7
2 changed files with 16 additions and 11 deletions
Download Patch File Download Diff File Expand all files Collapse all files

20
common/static/common/js/spec_helpers/spec_helpers.js
View File

@@ -13,9 +13,11 @@ define([], function () {
var withData = function (data, func) {
for (var name in data) {
if (data.hasOwnProperty(name)) {
it(name, function () {
func.apply(this, data[name]);
});
(function (name) {
it(name, function () {
func.apply(this, data[name]);
});
})(name);
}
}
};
@@ -31,12 +33,14 @@ define([], function () {
var withConfiguration = function (config, setup, test) {
for (var name in config) {
if (config.hasOwnProperty(name)) {
describe(name, function () {
beforeEach(function () {
setup.apply(this, config[name]);
(function (name) {
describe(name, function () {
beforeEach(function () {
setup.apply(this, config[name]);
});
test();
});
test();
});
})(name);
}
}
};

7
lms/djangoapps/teams/static/teams/js/spec/views/teams_tab_spec.js
View File

@@ -171,10 +171,11 @@ define([
]
}, function (url, expectedEvent) {
var teamsTabView = createTeamsTabView(this, {
userInfo: TeamSpecHelpers.createMockUserInfo({staff: true})
});
userInfo: TeamSpecHelpers.createMockUserInfo({staff: true})
});
teamsTabView.teamsCollection = TeamSpecHelpers.createMockTeams();
teamsTabView.router.navigate(url, {trigger: true});
if (AjaxHelpers.currentRequest(requests)) {
if (requests.length > requests.currentIndex) {
AjaxHelpers.respondWithJson(requests, {});
}
expect(Logger.log).toHaveBeenCalledWith('edx.team.page_viewed', expectedEvent);