Andal.LND/edx-platform
6
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Prefix status with Question number.

Browse Source 
TNL-5735
This commit is contained in:
cahrens
2016-10-14 15:14:06 -04:00
parent 971f102b1d
commit 485a88fabc
4 changed files with 16 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
common/lib/xmodule/xmodule/js/spec/capa/display_spec.coffee
View File

@@ -206,8 +206,8 @@ describe 'Problem', ->
describe 'when the response is correct', ->
it 'call render with returned content', ->
contents = '<section aria-label="Question 1"><p>Correct<span class="status">excellent</span></p></section>' +
'<section aria-label="Question 2"><p>Yep<span class="status">correct</span></p></section>'
contents = '<div class="wrapper-problem-response" aria-label="Question 1"><p>Correct<span class="status">excellent</span></p></div>' +
'<div class="wrapper-problem-response" aria-label="Question 2"><p>Yep<span class="status">correct</span></p></div>'
spyOn($, 'postWithPrefix').and.callFake (url, answers, callback) ->
callback(success: 'correct', contents: contents)
promise =

2
common/lib/xmodule/xmodule/js/src/capa/display.js
View File

@@ -640,7 +640,7 @@
labeledStatus = [];
for (i = 0, len = statusElement.length; i < len; i++) {
element = statusElement[i];
parentSection = $(element).closest('section');
parentSection = $(element).closest('.wrapper-problem-response');
addedStatus = false;
if (parentSection) {
ariaLabel = parentSection.attr('aria-label');

7
common/test/acceptance/pages/lms/problem.py
View File

@@ -383,3 +383,10 @@ class ProblemPage(PageObject):
"""
self.wait_for_element_visibility('.problem-progress', "Problem progress is visible")
return self.q(css='.problem-progress').text[0]
@property
def status_sr_text(self):
"""
Returns the text in the special "sr" region used for display status.
"""
return self.q(css='#reader-feedback').text[0]

6
common/test/acceptance/tests/lms/test_lms_problems.py
View File

@@ -205,17 +205,23 @@ class ProblemNotificationTests(ProblemsTest):
self.assertFalse(problem_page.is_success_notification_visible())
problem_page.click_submit()
problem_page.wait_success_notification()
self.assertEqual('Question 1: correct', problem_page.status_sr_text)
# Clicking Save should clear the submit notification
problem_page.click_save()
self.assertFalse(problem_page.is_success_notification_visible())
problem_page.wait_for_save_notification()
# Changing the answer should clear the save notification
problem_page.click_choice("choice_1")
self.assertFalse(problem_page.is_save_notification_visible())
problem_page.click_save()
problem_page.wait_for_save_notification()
# Submitting the problem again should clear the save notification
problem_page.click_submit()
problem_page.wait_incorrect_notification()
self.assertEqual('Question 1: incorrect', problem_page.status_sr_text)
self.assertFalse(problem_page.is_save_notification_visible())