Andal.LND/edx-platform
6
0
Fork 0
Code Issues Pull Requests Actions 1 Packages Projects Releases Wiki Activity

Make mapping from xml attributes to metadata values less manual

Browse Source
This commit is contained in:
Calen Pennington
2012-07-02 20:46:41 -04:00
parent e7d44a2606
commit 3cef71431e
1 changed files with 16 additions and 10 deletions
Download Patch File Download Diff File Expand all files Collapse all files

26
common/lib/xmodule/xmodule/xml_module.py
View File

@@ -71,6 +71,13 @@ class XmlDescriptor(XModuleDescriptor):
metadata_attributes = ('format', 'graceperiod', 'showanswer', 'rerandomize',
'due', 'graded', 'name', 'slug')
# A dictionary mapping xml attribute names to function of the value
# that return the metadata key and value
xml_attribute_map = {
'graded': lambda val: ('graded', val == 'true'),
'name': lambda val: ('display_name', val),
}
@classmethod
def definition_from_xml(cls, xml_object, system):
"""
@@ -116,16 +123,15 @@ class XmlDescriptor(XModuleDescriptor):
def metadata_loader():
metadata = {}
for attr in ('format', 'graceperiod', 'showanswer', 'rerandomize', 'due'):
from_xml = xml_object.get(attr)
if from_xml is not None:
metadata[attr] = from_xml
if xml_object.get('graded') is not None:
metadata['graded'] = xml_object.get('graded') == 'true'
if xml_object.get('name') is not None:
metadata['display_name'] = xml_object.get('name')
for attr in cls.metadata_attributes:
val = xml_object.get(attr)
if val is not None:
map_fn = cls.xml_attribute_map.get(attr)
if map_fn is None:
metadata[attr] = val
else:
key, val = map_fn(val)
metadata[key] = val
return metadata