fix for some broken github edit links - avoids symlinks

This commit is contained in:
ichuang
2012-08-05 11:39:56 -04:00
parent 1ff49aa3f9
commit 3c23235885
3 changed files with 10 additions and 7 deletions

View File

@@ -90,9 +90,12 @@ def add_histogram(get_html, module):
# TODO (ichuang): Remove after fall 2012 LMS migration done
if settings.MITX_FEATURES.get('ENABLE_LMS_MIGRATION'):
filename = module.definition.get('filename','')
data_dir = module.system.filestore.root_path.rsplit('/')[-1]
edit_link = "https://github.com/MITx/%s/tree/master/%s" % (data_dir,filename)
[filepath, filename] = module.definition.get('filename','')
osfs = module.system.filestore
if osfs.exists(filename):
filepath = filename # if original, unmangled filename exists then use it (github doesn't like symlinks)
data_dir = osfs.root_path.rsplit('/')[-1]
edit_link = "https://github.com/MITx/%s/tree/master/%s" % (data_dir,filepath)
else:
edit_link = False

View File

@@ -98,8 +98,8 @@ class HtmlDescriptor(XmlDescriptor, EditingDescriptor):
definition = {'data' : html}
# TODO (ichuang): remove this after migration
# for Fall 2012 LMS migration: keep filename
definition['filename'] = filepath
# for Fall 2012 LMS migration: keep filename (and unmangled filename)
definition['filename'] = [ filepath, filename ]
return definition

View File

@@ -141,8 +141,8 @@ class XmlDescriptor(XModuleDescriptor):
definition = cls.definition_from_xml(definition_xml, system)
# TODO (ichuang): remove this after migration
# for Fall 2012 LMS migration: keep filename
definition['filename'] = filepath
# for Fall 2012 LMS migration: keep filename (and unmangled filename)
definition['filename'] = [ filepath, filename ]
return definition