Andal.LND/edx-platform
6
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Fix a decode error in course_about.html and make some string translatable

Browse Source 
The strings in share links should be in unicode, otherwise when the name of a course is non-ascii, it will generate a decode error.
And some of these strings is actually translatable, so they should be collected into mako.po.
This commit is contained in:
louyihua
2014-04-01 22:25:35 +08:00
parent 8708c37a01
commit 3b14ee8a04
1 changed files with 12 additions and 9 deletions
Download Patch File Download Diff File Expand all files Collapse all files

21
lms/templates/courseware/course_about.html
View File

@@ -236,30 +236,33 @@
site_domain = microsite.get_value('site_domain', 'www.edx.org')
platform_name = microsite.get_value('platform_name', 'edX')
tweet_action = "http://twitter.com/intent/tweet?text=I+just+registered+for+{number}+{title}+through+{account}:+{url}".format(
# Translators: This text will be automatically posted to the student's
# Twitter account. {url} should appear at the end of the text.
tweet_text = _("I just registered for {number} {title} through {account}: {url}").format(
number=course.number,
title=get_course_about_section(course, 'title').encode('utf-8'),
title=get_course_about_section(course, 'title'),
account=microsite.get_value('course_about_twitter_account', '@edxonline'),
url="http://{domain}{path}".format(
url=u"http://{domain}{path}".format(
domain=site_domain,
path=reverse('about_course', args=[course.id])
)
)
).replace(u" ", u"+")
tweet_action = u"http://twitter.com/intent/tweet?text={tweet_text}".format(tweet_text=tweet_text)
facebook_link = microsite.get_value('course_about_facebook_link', 'http://www.facebook.com/EdxOnline')
email_subject = "mailto:?subject={subject}&body={body}".format(
subject="Take a course with {platform} online".format(platform=platform_name),
body="I just registered for {number} {title} through {platform} {url}".format(
email_subject = u"mailto:?subject={subject}&body={body}".format(
subject=_("Take a course with {platform} online").format(platform=platform_name),
body=_("I just registered for {number} {title} through {platform} {url}").format(
number=course.number,
title=get_course_about_section(course, 'title'),
platform=platform_name,
url="http://{domain}{path}".format(
url=u"http://{domain}{path}".format(
domain=site_domain,
path=reverse('about_course', args=[course.id]),
)
)
).replace(" ", "%20")
).replace(u" ", u"%20")
%>
<a href="${tweet_action}" class="share">
<img src="${static.url('images/social/twitter-sharing.png')}" alt="Tweet that you've registered for this course">