removed global staff check
This commit is contained in:
@@ -322,9 +322,6 @@ def certificate_activation_handler(request, course_key_string):
|
||||
POST
|
||||
json: is_active. update the activation state of certificate
|
||||
"""
|
||||
# Only global staff (PMs) are able to activate/deactivate certificate configuration
|
||||
if not GlobalStaff().has_user(request.user):
|
||||
raise PermissionDenied()
|
||||
course_key = CourseKey.from_string(course_key_string)
|
||||
store = modulestore()
|
||||
try:
|
||||
|
||||
@@ -812,28 +812,6 @@ class CertificatesDetailHandlerTestCase(
|
||||
)
|
||||
self.assertEquals(response.status_code, 403)
|
||||
|
||||
@ddt.data(*itertools.product([True, False], [C4X_SIGNATORY_PATH, SIGNATORY_PATH]))
|
||||
@ddt.unpack
|
||||
def test_certificate_activation_without_global_staff_permissions(self, activate, signatory_path):
|
||||
"""
|
||||
Tests certificate Activate and Deactivate should not be allowed if user
|
||||
does not have global staff permissions on course.
|
||||
"""
|
||||
test_url = reverse_course_url('certificates.certificate_activation_handler', self.course.id)
|
||||
self._add_course_certificates(count=1, signatory_count=2, asset_path_format=signatory_path)
|
||||
user = UserFactory()
|
||||
for role in [CourseInstructorRole, CourseStaffRole]:
|
||||
role(self.course.id).add_users(user)
|
||||
self.client.login(username=user.username, password='test')
|
||||
response = self.client.post(
|
||||
test_url,
|
||||
data=json.dumps({"is_active": activate}),
|
||||
content_type="application/json",
|
||||
HTTP_ACCEPT="application/json",
|
||||
HTTP_X_REQUESTED_WITH="XMLHttpRequest"
|
||||
)
|
||||
self.assertEquals(response.status_code, 403)
|
||||
|
||||
@ddt.data(C4X_SIGNATORY_PATH, SIGNATORY_PATH)
|
||||
def test_certificate_activation_failure(self, signatory_path):
|
||||
"""
|
||||
|
||||
@@ -83,12 +83,6 @@ function(_, $, Course, CertificatePreview, TemplateHelpers, ViewHelpers, AjaxHel
|
||||
expect(this.view.toggleCertificateActivation).toHaveBeenCalled();
|
||||
});
|
||||
|
||||
it('toggle certificate activation button should not be present if user is not global staff', function() {
|
||||
window.CMS.User = {isGlobalStaff: false};
|
||||
appendSetFixtures(this.view.render().el);
|
||||
expect(this.view.$(SELECTORS.activate_certificate)).not.toExist();
|
||||
});
|
||||
|
||||
it('certificate deactivation works fine', function() {
|
||||
var requests = AjaxHelpers.requests(this),
|
||||
notificationSpy = ViewHelpers.createNotificationSpy();
|
||||
|
||||
@@ -7,7 +7,6 @@
|
||||
<a href=<%= certificate_web_view_url %> class="button preview-certificate-link" target="_blank">
|
||||
<%= gettext("Preview Certificate") %>
|
||||
</a>
|
||||
<% if (CMS.User.isGlobalStaff) { %>
|
||||
<button class="button activate-cert">
|
||||
<span>
|
||||
<% if(!is_active) { %>
|
||||
@@ -16,4 +15,3 @@
|
||||
<%= gettext("Deactivate") %></span>
|
||||
<% } %>
|
||||
</button>
|
||||
<% } %>
|
||||
|
||||
Reference in New Issue
Block a user