Andal.LND/edx-platform
6
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Use singular getter function where only one requirement is expected

Browse Source 
This avoids a fatal error in Django 1.9+ in most scenarios, where this
code (before this commit) will no longer result in an implicit __in
query.  This commit should be a no-op functionally for Django 1.8.

More info: https://code.djangoproject.com/ticket/25284

PLAT-1525
This commit is contained in:
Troy Sankey
2017-10-16 13:29:54 -04:00
parent 4a13f9bf53
commit 2eba1b5122
2 changed files with 2 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
openedx/core/djangoapps/credit/api/eligibility.py
View File

@@ -297,7 +297,7 @@ def remove_credit_requirement_status(username, course_key, req_namespace, req_na
"""
# Find the requirement we're trying to remove
req_to_remove = CreditRequirement.get_course_requirements(course_key, namespace=req_namespace, name=req_name)
req_to_remove = CreditRequirement.get_course_requirement(course_key, req_namespace, req_name)
# If we can't find the requirement, then the most likely explanation
# is that there was a lag removing the credit requirements after the course

2
openedx/core/djangoapps/credit/models.py
View File

@@ -385,7 +385,7 @@ class CreditRequirement(TimeStampedModel):
name(str): Name of credit course requirement
Returns:
CreditRequirement object if exists
CreditRequirement object if exists, None otherwise.
"""
try: