Andal.LND/edx-platform
6
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Merge pull request #37395 from asajjad2/areeb/discussions-edit-errant-string

Browse Source 
fix: prevent errant body string on title edit
This commit is contained in:
Peter Pinch
2025-10-20 08:32:56 -04:00
committed by GitHub
parent 71989bd67c 2b0982f2da
commit 264198f013
2 changed files with 47 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
common/static/common/js/discussion/views/discussion_thread_edit_view.js
View File

@@ -7,7 +7,10 @@
tagName: 'form',
events: {
submit: 'updateHandler',
'click .post-cancel': 'cancelHandler'
'click .post-cancel': 'cancelHandler',
'keypress input:not(.wmd-input)': function(event) {
return DiscussionUtil.ignoreEnterKey(event);
}
},
attributes: {

43
common/static/common/js/spec/discussion/view/discussion_thread_edit_view_spec.js
View File

@@ -93,6 +93,49 @@
testCancel(this.view);
});
describe('Enter key behavior in title input', function() {
beforeEach(function() {
this.createEditView();
this.titleInput = this.view.$('.edit-post-title');
});
it('prevents form submission when Enter is pressed in title input', function() {
var submitSpy = jasmine.createSpy('submitSpy');
this.view.$el.on('submit', submitSpy);
var enterKeyEvent = $.Event('keypress', {which: 13, keyCode: 13});
this.titleInput.trigger(enterKeyEvent);
expect(submitSpy).not.toHaveBeenCalled();
});
it('prevents default behavior when Enter is pressed in title input', function() {
var enterKeyEvent = $.Event('keypress', {which: 13, keyCode: 13});
var preventDefaultSpy = spyOn(enterKeyEvent, 'preventDefault');
this.titleInput.trigger(enterKeyEvent);
expect(preventDefaultSpy).toHaveBeenCalled();
});
it('does not prevent non-Enter key presses in title input', function() {
var submitSpy = jasmine.createSpy('submitSpy');
this.view.$el.on('submit', submitSpy);
var aKeyEvent = $.Event('keypress', {which: 65, keyCode: 65});
var preventDefaultSpy = spyOn(aKeyEvent, 'preventDefault');
this.titleInput.trigger(aKeyEvent);
expect(preventDefaultSpy).not.toHaveBeenCalled();
});
it('does not interfere with body editor when Enter is pressed', function() {
var bodyEditor = this.view.$('.edit-post-body textarea');
var enterKeyEvent = $.Event('keypress', {which: 13, keyCode: 13});
var preventDefaultSpy = spyOn(enterKeyEvent, 'preventDefault');
bodyEditor.trigger(enterKeyEvent);
expect(preventDefaultSpy).not.toHaveBeenCalled();
});
});
describe('renderComments', function() {
beforeEach(function() {
this.course_settings = new DiscussionCourseSettings({