Andal.LND/edx-platform
6
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

fix: hide new provider if flag disabled (#30925)

Browse Source
This commit is contained in:
AsadAzam
2022-08-31 18:29:53 +05:00
committed by GitHub
parent dc256139f3
commit 21e9490c66
2 changed files with 9 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
openedx/core/djangoapps/discussions/tests/test_views.py
View File

@@ -424,7 +424,10 @@ class DataTest(AuthorizedApiTest, DataTestMixin):
with override_waffle_flag(ENABLE_NEW_STRUCTURE_DISCUSSIONS, new_structure_enabled):
response = self._get()
data = response.json()
for visible_provider in [Provider.OPEN_EDX, Provider.LEGACY]:
visible_providers = [Provider.OPEN_EDX, Provider.LEGACY]
if not new_structure_enabled:
visible_providers = [Provider.LEGACY]
for visible_provider in visible_providers:
assert visible_provider in data['providers']['available'].keys()
@ddt.data(

5
openedx/core/djangoapps/discussions/views.py
View File

@@ -183,6 +183,11 @@ class DiscussionsProvidersView(APIView):
else:
if configuration.provider_type != Provider.OPEN_EDX:
hidden_providers.append(Provider.OPEN_EDX)
else:
# if new discussions is not enabled, hide the new provider in case it is not already in use
if not ENABLE_NEW_STRUCTURE_DISCUSSIONS.is_enabled(course_key):
if configuration.provider_type != Provider.OPEN_EDX:
hidden_providers.append(Provider.OPEN_EDX)
serializer = DiscussionsProvidersSerializer(
{