Andal.LND/edx-platform
6
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Speed improvements by making the mako rendering in CustomTagModule lazy.

Browse Source
This commit is contained in:
Bridger Maxwell
2012-08-07 16:01:42 -04:00
parent a9d67c3e8d
commit 1f34cf33fa
1 changed files with 11 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

16
common/lib/xmodule/xmodule/template_module.py
View File

@@ -2,6 +2,7 @@ from xmodule.x_module import XModule
from xmodule.raw_module import RawDescriptor
from lxml import etree
from mako.template import Template
from util.decorators import lazyproperty
class CustomTagModule(XModule):
@@ -33,21 +34,26 @@ class CustomTagModule(XModule):
xmltree = etree.fromstring(self.definition['data'])
if 'impl' in xmltree.attrib:
template_name = xmltree.attrib['impl']
self._template_name = xmltree.attrib['impl']
else:
# VS[compat] backwards compatibility with old nested customtag structure
child_impl = xmltree.find('impl')
if child_impl is not None:
template_name = child_impl.text
self._template_name = child_impl.text
else:
# TODO (vshnayder): better exception type
raise Exception("Could not find impl attribute in customtag {0}"
.format(location))
self._params = dict(xmltree.items())
params = dict(xmltree.items())
@lazyproperty
def html(self):
with self.system.filestore.open(
'custom_tags/{name}'.format(name=template_name)) as template:
self.html = Template(template.read()).render(**params)
'custom_tags/{name}'.format(name=self._template_name)) as template:
return Template(template.read()).render(**self._params)
def get_html(self):
return self.html