Merge PR #24803: [BD-14] BlockLimitReachedError should returns a 400 response instead of 500

https://github.com/edx/edx-platform/pull/24803
This commit is contained in:
Braden MacDonald
2020-08-31 10:39:20 -07:00
committed by GitHub
2 changed files with 5 additions and 4 deletions

View File

@@ -500,8 +500,6 @@ class ContentLibrariesTest(ContentLibrariesRestApiTest):
lib_id = lib["id"]
block_data = self._add_block_to_library(lib_id, "unit", "unit1")
# Second block should throw error
with self.assertRaises(BlockLimitReachedError):
self._add_block_to_library(lib_id, "problem", "problem1")
self._add_block_to_library(lib_id, "problem", "problem1", expect_response=400)
# Also check that limit applies to child blocks too
with self.assertRaises(BlockLimitReachedError):
self._add_block_to_library(lib_id, "html", "html1", parent_block=block_data["id"])
self._add_block_to_library(lib_id, "html", "html1", parent_block=block_data['id'], expect_response=400)

View File

@@ -60,6 +60,9 @@ def convert_exceptions(fn):
except api.InvalidNameError as exc:
log.exception(str(exc))
raise ValidationError(str(exc))
except api.BlockLimitReachedError as exc:
log.exception(str(exc))
raise ValidationError(str(exc))
return wrapped_fn