Andal.LND/edx-platform
6
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Drop setting attributes for the size of each cookie.

Browse Source 
Setting a new metric per cookie name resulted in a lot of metrics
getting added to New Relic.  In some cases, this was causing other
more important metrics to not get registered.
This commit is contained in:
Feanil Patel
2021-01-14 09:56:01 -05:00
parent 1ae50fc466
commit 1a1da89f55
2 changed files with 2 additions and 16 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
openedx/core/lib/request_utils.py
View File

@@ -152,11 +152,8 @@ class CookieMonitoringMiddleware(MiddlewareMixin):
max_group_cookie_name = max_cookie_name
max_group_cookie_size = max_cookie_size
for name, size in cookie_names_to_size.items():
attribute_name = 'cookies.{}.size'.format(name)
set_custom_attribute(attribute_name, size)
log.debug(u'%s = %d', attribute_name, size)
# Only log the groups because adding an arbitrary number of individual cookies pushes too many
# metrics into NR and results in other metrics getting dropped potentially.
for name, size in cookie_groups_to_size.items():
attribute_name = 'cookies.{}.group.size'.format(name)
set_custom_attribute(attribute_name, size)

11
openedx/core/lib/tests/test_request_utils.py
View File

@@ -114,14 +114,6 @@ class RequestUtilTestCase(unittest.TestCase):
middleware.process_request(mock_request)
mock_set_custom_attribute.assert_has_calls([
call('cookies.a.size', 100),
call('cookies._b.size', 13),
call('cookies._c_.size', 13),
call('cookies.a.b.size', 10),
call('cookies.a.c.size', 10),
call('cookies.b..size', 13),
call('cookies.b_a.size', 15),
call('cookies.b_c.size', 15),
call('cookies.a.group.size', 20),
call('cookies.b.group.size', 43),
call('cookies.max.name', 'a'),
@@ -149,9 +141,6 @@ class RequestUtilTestCase(unittest.TestCase):
middleware.process_request(mock_request)
mock_set_custom_attribute.assert_has_calls([
call('cookies.a.size', 10),
call('cookies.b_a.size', 15),
call('cookies.b_c.size', 20),
call('cookies.b.group.size', 35),
call('cookies.max.name', 'b_c'),
call('cookies.max.size', 20),