Andal.LND/edx-platform
6
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Logging improved for case exception raised during submission to SoftwareSecure.

Browse Source
This commit is contained in:
Noraiz
2016-10-21 11:09:40 +05:00
committed by Noraiz Anwar
parent c604cada09
commit 067ca02196
2 changed files with 15 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
lms/djangoapps/verify_student/models.py
View File

@@ -721,8 +721,11 @@ class SoftwareSecurePhotoVerification(PhotoVerification):
self.status = "must_retry"
self.error_msg = response.text
self.save()
except Exception as error:
log.exception(error)
except Exception: # pylint: disable=broad-except
log.exception(
'Software Secure submission failed for user %s, setting status to must_retry',
self.user.username
)
self.status = "must_retry"
self.save()

13
lms/djangoapps/verify_student/tests/test_models.py
View File

@@ -12,6 +12,7 @@ from mock import patch
from nose.tools import assert_is_none, assert_equals, assert_raises, assert_true, assert_false # pylint: disable=no-name-in-module
import pytz
import requests.exceptions
from testfixtures import LogCapture
from common.test.utils import MockS3Mixin
from student.tests.factories import UserFactory
@@ -28,6 +29,7 @@ from lms.djangoapps.verify_student.models import (
VerificationDeadline
)
FAKE_SETTINGS = {
"SOFTWARE_SECURE": {
"FACE_IMAGE_AES_KEY": "AAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAA",
@@ -204,10 +206,15 @@ class TestPhotoVerification(MockS3Mixin, ModuleStoreTestCase):
attempt = self.create_and_submit()
assert_equals(attempt.status, "must_retry")
# We try to post, but run into an error (in this case a newtork connection error)
# We try to post, but run into an error (in this case a network connection error)
with patch('lms.djangoapps.verify_student.models.requests.post', new=mock_software_secure_post_unavailable):
attempt = self.create_and_submit()
assert_equals(attempt.status, "must_retry")
with LogCapture('lms.djangoapps.verify_student.models') as logger:
attempt = self.create_and_submit()
assert_equals(attempt.status, "must_retry")
logger.check(
('lms.djangoapps.verify_student.models', 'ERROR',
'Software Secure submission failed for user %s, setting status to must_retry'
% attempt.user.username))
@mock.patch.dict(settings.FEATURES, {'AUTOMATIC_VERIFY_STUDENT_IDENTITY_FOR_TESTING': True})
def test_submission_while_testing_flag_is_true(self):