Merge pull request #33501 from Inferato/lytvynenko/additional_name_check

Name length validation
This commit is contained in:
Jason Wesson
2023-12-04 11:55:21 -08:00
committed by GitHub
2 changed files with 13 additions and 1 deletions

View File

@@ -420,6 +420,10 @@ def get_name_validation_error(name):
return bool(regex)
if name:
# Validation for the name length
if len(name) > 255:
return _("Full name can't be longer than 255 symbols")
return _('Enter a valid name') if (contains_html(name) or contains_url(name)) else ''
else:
return accounts.REQUIRED_FIELD_NAME_MSG

View File

@@ -34,7 +34,8 @@ from openedx.core.djangoapps.ace_common.tests.mixins import EmailTemplateTagMixi
from openedx.core.djangoapps.user_api.accounts import PRIVATE_VISIBILITY
from openedx.core.djangoapps.user_api.accounts.api import (
get_account_settings,
update_account_settings
update_account_settings,
get_name_validation_error
)
from openedx.core.djangoapps.user_api.accounts.tests.retirement_helpers import ( # pylint: disable=unused-import
RetirementTestCase,
@@ -570,6 +571,13 @@ class TestAccountApi(UserSettingsEventTestMixin, EmailTemplateTagMixin, CreateAc
assert account_settings['country'] is None
assert account_settings['state'] is None
def test_get_name_validation_error_too_long(self):
"""
Test validation error when the name is too long.
"""
result = get_name_validation_error("A" * 256)
assert result == "Full name can't be longer than 255 symbols"
@patch('openedx.core.djangoapps.user_api.accounts.image_helpers._PROFILE_IMAGE_SIZES', [50, 10])
@patch.dict(