fix: streak celebration feature should require progress milestones (#26922)

In commit 9b37e7d0, the logic of
`streak_celebration_is_active` was accidentally
changed such that it no longer checks the
Progress Milestones waffle flag.
This commit fixes that.

Note: This also adds in a transitive check to
`courseware_mfe_is_active`,
which makes sense for Streak Celebration
and should not have any functional impact.
This commit is contained in:
Kyle McCormick
2021-03-09 10:23:13 -05:00
committed by GitHub
parent e624a8f4ac
commit 05dbd83290

View File

@@ -205,6 +205,6 @@ def courseware_mfe_progress_milestones_are_active(course_key):
def streak_celebration_is_active(course_key):
return (
courseware_mfe_is_active(course_key) and
courseware_mfe_progress_milestones_are_active(course_key) and
COURSEWARE_MICROFRONTEND_PROGRESS_MILESTONES_STREAK_CELEBRATION.is_enabled(course_key)
)