Andal.LND/edx-platform
6
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

chore: add monitoring on course strcuture cache failure (#32831)

Browse Source
This commit is contained in:
Muhammad Umar Khan
2023-07-25 14:49:43 +05:00
committed by GitHub
parent a44c6d3d4a
commit 004a0f5c75
2 changed files with 19 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files

20
xmodule/modulestore/split_mongo/mongo_connection.py
View File

@@ -20,6 +20,7 @@ import pytz
from mongodb_proxy import autoretry_read
# Import this just to export it
from pymongo.errors import DuplicateKeyError # pylint: disable=unused-import
from edx_django_utils import monitoring
from edx_django_utils.cache import RequestCache
from common.djangoapps.split_modulestore_django.models import SplitModulestoreCourseIndex
@@ -245,12 +246,19 @@ class CourseStructureCache:
data_size = len(compressed_pickled_data)
tagger.measure('compressed_size', data_size)
total_bytes_in_one_mb = 1024 * 1024
# only print logs when data size is greater than or equal to 1MB
if data_size >= total_bytes_in_one_mb:
log.info('Data to be cached is: {:.2f} MB'.format(data_size / total_bytes_in_one_mb))
# Stuctures are immutable, so we set a timeout of "never"
self.cache.set(key, compressed_pickled_data, None)
# Structures are immutable, so we set a timeout of "never"
try:
self.cache.set(key, compressed_pickled_data, None)
except Exception: # pylint: disable=broad-except
total_bytes_in_one_mb = 1024 * 1024
chunk_size_in_mbs = round(data_size / total_bytes_in_one_mb, 2)
# .. custom_attribute_name: split_mongo_compressed_size
# .. custom_attribute_description: contains the data chunk size in MBs. The size on which
# the memcached client failed to store value in course structure cache.
monitoring.set_custom_attribute('split_mongo_compressed_size', chunk_size_in_mbs)
monitoring.record_exception()
log.info('Data caching (course structure) failed on chunk size: {} MB'.format(chunk_size_in_mbs))
class MongoPersistenceBackend:

7
xmodule/modulestore/tests/test_split_modulestore.py
View File

@@ -842,10 +842,13 @@ class TestCourseStructureCache(CacheIsolationMixin, SplitModuleTest):
# now make sure that you get the same structure
assert cached_structure == not_cached_structure
@patch('django.core.cache.cache.set')
@patch('xmodule.modulestore.split_mongo.mongo_connection.get_cache')
def test_course_structure_cache_with_data_chunk_greater_than_one_mb(self, mock_get_cache):
def test_course_structure_cache_with_data_chunk_greater_than_one_mb(self, mock_get_cache, mock_set_cache):
enabled_cache = caches['default']
mock_get_cache.return_value = enabled_cache
mock_set_cache.side_effect = Exception
course_cache = CourseStructureCache()
size = 300000000
@@ -853,7 +856,7 @@ class TestCourseStructureCache(CacheIsolationMixin, SplitModuleTest):
data_chunk = b'\x00' * size
logger_name = 'xmodule.modulestore.split_mongo.mongo_connection'
expected_message = 'Data to be cached is: 1.25 MB'
expected_message = 'Data caching (course structure) failed on chunk size: 1.25 MB'
with LogCapture(logger_name) as capture:
course_cache.set('my_data_chunk', data_chunk)