Compare commits

..

8 Commits

Author SHA1 Message Date
Syed Ali Abbas Zaidi
1294f0bbf8 build: bump frontend-build to alpha 2023-08-01 15:47:41 +05:00
renovate[bot]
4b89e7561f chore(deps): update dependency jest to v29.6.2 2023-07-31 09:53:25 +00:00
renovate[bot]
da08e721c2 chore(deps): update dependency @edx/frontend-build to v12.9.3 2023-07-31 07:34:58 +00:00
renovate[bot]
d037e96a0c chore(deps): update dependency @testing-library/jest-dom to v5.17.0 2023-07-24 12:16:59 +00:00
renovate[bot]
050dd30d8f chore(deps): update dependency @edx/frontend-build to v12.9.2 2023-07-24 09:55:32 +00:00
renovate[bot]
3dd41030d3 fix(deps): update dependency @edx/paragon to v20.45.5 2023-07-24 06:29:20 +00:00
Awais Ansari
27228f093d Merge pull request #370 from openedx/Ayesha/INF-951
fix: clicking on notification redirecting to correct URL
2023-07-14 13:04:49 +05:00
ayeshoali
e153aefc13 fix: clicking on notification redirecting to correct URL 2023-07-13 15:48:35 +05:00
3 changed files with 5223 additions and 4000 deletions

9205
package-lock.json generated

File diff suppressed because it is too large Load Diff

View File

@@ -35,16 +35,16 @@
"devDependencies": { "devDependencies": {
"@edx/brand": "npm:@edx/brand-openedx@1.2.0", "@edx/brand": "npm:@edx/brand-openedx@1.2.0",
"@edx/browserslist-config": "^1.1.1", "@edx/browserslist-config": "^1.1.1",
"@edx/frontend-build": "12.8.61", "@edx/frontend-build": "12.9.0-alpha.1",
"@edx/frontend-platform": "4.6.0", "@edx/frontend-platform": "4.6.1",
"@edx/reactifex": "^2.1.1", "@edx/reactifex": "^2.1.1",
"@testing-library/dom": "9.3.1", "@testing-library/dom": "9.3.1",
"@testing-library/jest-dom": "5.16.5", "@testing-library/jest-dom": "5.17.0",
"@testing-library/react": "10.4.9", "@testing-library/react": "10.4.9",
"@wojtekmaj/enzyme-adapter-react-17": "0.8.0", "@wojtekmaj/enzyme-adapter-react-17": "0.8.0",
"enzyme": "3.11.0", "enzyme": "3.11.0",
"husky": "8.0.3", "husky": "8.0.3",
"jest": "29.6.1", "jest": "29.6.2",
"jest-chain": "1.1.6", "jest-chain": "1.1.6",
"prop-types": "15.8.1", "prop-types": "15.8.1",
"react": "17.0.2", "react": "17.0.2",
@@ -56,7 +56,7 @@
"redux-saga": "1.2.3" "redux-saga": "1.2.3"
}, },
"dependencies": { "dependencies": {
"@edx/paragon": "20.45.0", "@edx/paragon": "20.45.5",
"@fortawesome/fontawesome-svg-core": "6.4.0", "@fortawesome/fontawesome-svg-core": "6.4.0",
"@fortawesome/free-brands-svg-icons": "6.4.0", "@fortawesome/free-brands-svg-icons": "6.4.0",
"@fortawesome/free-regular-svg-icons": "6.4.0", "@fortawesome/free-regular-svg-icons": "6.4.0",

View File

@@ -3,7 +3,6 @@ import { useDispatch } from 'react-redux';
import { useIntl } from '@edx/frontend-platform/i18n'; import { useIntl } from '@edx/frontend-platform/i18n';
import PropTypes from 'prop-types'; import PropTypes from 'prop-types';
import { Icon } from '@edx/paragon'; import { Icon } from '@edx/paragon';
import { Link } from 'react-router-dom';
import * as timeago from 'timeago.js'; import * as timeago from 'timeago.js';
import { getIconByType } from './utils'; import { getIconByType } from './utils';
import { markNotificationsAsRead } from './data/thunks'; import { markNotificationsAsRead } from './data/thunks';
@@ -24,12 +23,13 @@ const NotificationRowItem = ({
const { icon: iconComponent, class: iconClass } = getIconByType(type); const { icon: iconComponent, class: iconClass } = getIconByType(type);
return ( return (
<Link <a
target="_blank" target="_blank"
className="d-flex mb-2 align-items-center text-decoration-none" className="d-flex mb-2 align-items-center text-decoration-none"
to={contentUrl} href={contentUrl}
onClick={handleMarkAsRead} onClick={handleMarkAsRead}
data-testid={`notification-${id}`} data-testid={`notification-${id}`}
rel="noopener noreferrer"
> >
<Icon <Icon
src={iconComponent} src={iconComponent}
@@ -62,7 +62,7 @@ const NotificationRowItem = ({
)} )}
</div> </div>
</div> </div>
</Link> </a>
); );
}; };