Compare commits

...

2 Commits

Author SHA1 Message Date
Awais Ansari
27228f093d Merge pull request #370 from openedx/Ayesha/INF-951
fix: clicking on notification redirecting to correct URL
2023-07-14 13:04:49 +05:00
ayeshoali
e153aefc13 fix: clicking on notification redirecting to correct URL 2023-07-13 15:48:35 +05:00

View File

@@ -3,7 +3,6 @@ import { useDispatch } from 'react-redux';
import { useIntl } from '@edx/frontend-platform/i18n'; import { useIntl } from '@edx/frontend-platform/i18n';
import PropTypes from 'prop-types'; import PropTypes from 'prop-types';
import { Icon } from '@edx/paragon'; import { Icon } from '@edx/paragon';
import { Link } from 'react-router-dom';
import * as timeago from 'timeago.js'; import * as timeago from 'timeago.js';
import { getIconByType } from './utils'; import { getIconByType } from './utils';
import { markNotificationsAsRead } from './data/thunks'; import { markNotificationsAsRead } from './data/thunks';
@@ -24,12 +23,13 @@ const NotificationRowItem = ({
const { icon: iconComponent, class: iconClass } = getIconByType(type); const { icon: iconComponent, class: iconClass } = getIconByType(type);
return ( return (
<Link <a
target="_blank" target="_blank"
className="d-flex mb-2 align-items-center text-decoration-none" className="d-flex mb-2 align-items-center text-decoration-none"
to={contentUrl} href={contentUrl}
onClick={handleMarkAsRead} onClick={handleMarkAsRead}
data-testid={`notification-${id}`} data-testid={`notification-${id}`}
rel="noopener noreferrer"
> >
<Icon <Icon
src={iconComponent} src={iconComponent}
@@ -62,7 +62,7 @@ const NotificationRowItem = ({
)} )}
</div> </div>
</div> </div>
</Link> </a>
); );
}; };