Andal.LND/frontend-component-header
4
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

fix: use LOGO_URL and move to GH actions (#81)

Browse Source 
* fix: use LOGO_URL and move to GH actions

* fix: duplicate i18n message id
This commit is contained in:
Adam Stankiewicz
2020-12-01 09:48:38 -05:00
committed by GitHub
parent 78573e30f1
commit 14fe2d9bc6
7 changed files with 74 additions and 28 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
src/Header.jsx
View File

@@ -20,7 +20,7 @@ ensureConfig([
'LOGOUT_URL',
'LOGIN_URL',
'SITE_NAME',
'LOGO_TRADEMARK_URL',
'LOGO_URL',
], 'Header component');
subscribe(APP_CONFIG_INITIALIZED, () => {
@@ -77,7 +77,7 @@ function Header({ intl }) {
];
const props = {
logo: config.LOGO_TRADEMARK_URL,
logo: config.LOGO_URL,
logoAltText: config.SITE_NAME,
siteName: config.SITE_NAME,
logoDestination: `${config.LMS_BASE_URL}/dashboard`,

2
src/Header.messages.jsx
View File

@@ -67,7 +67,7 @@ const messages = defineMessages({
description: 'The aria label for the account menu trigger',
},
'header.label.account.menu.for': {
id: 'header.label.account.menu',
id: 'header.label.account.menu.for',
defaultMessage: 'Account menu for {username}',
description: 'The aria label for the account menu trigger when the username is displayed in it',
},

8
src/Header.test.jsx
View File

@@ -19,7 +19,7 @@ describe('<Header />', () => {
SITE_NAME: process.env.SITE_NAME,
LOGIN_URL: process.env.LOGIN_URL,
LOGOUT_URL: process.env.LOGOUT_URL,
LOGO_TRADEMARK_URL: process.env.LOGO_TRADEMARK_URL,
LOGO_URL: process.env.LOGO_URL,
},
}}
>
@@ -51,7 +51,7 @@ describe('<Header />', () => {
SITE_NAME: process.env.SITE_NAME,
LOGIN_URL: process.env.LOGIN_URL,
LOGOUT_URL: process.env.LOGOUT_URL,
LOGO_TRADEMARK_URL: process.env.LOGO_TRADEMARK_URL,
LOGO_URL: process.env.LOGO_URL,
},
}}
>
@@ -78,7 +78,7 @@ describe('<Header />', () => {
SITE_NAME: process.env.SITE_NAME,
LOGIN_URL: process.env.LOGIN_URL,
LOGOUT_URL: process.env.LOGOUT_URL,
LOGO_TRADEMARK_URL: process.env.LOGO_TRADEMARK_URL,
LOGO_URL: process.env.LOGO_URL,
},
}}
>
@@ -110,7 +110,7 @@ describe('<Header />', () => {
SITE_NAME: process.env.SITE_NAME,
LOGIN_URL: process.env.LOGIN_URL,
LOGOUT_URL: process.env.LOGOUT_URL,
LOGO_TRADEMARK_URL: process.env.LOGO_TRADEMARK_URL,
LOGO_URL: process.env.LOGO_URL,
},
}}
>

8
src/__snapshots__/Header.test.jsx.snap
View File

@@ -17,7 +17,7 @@ exports[`<Header /> renders correctly for anonymous desktop 1`] = `
<img
alt="edX"
className="d-block"
src="https://edx-cdn.org/v3/default/logo-trademark.svg"
src="https://edx-cdn.org/v3/default/logo.svg"
/>
</a>
<nav
@@ -126,7 +126,7 @@ exports[`<Header /> renders correctly for anonymous mobile 1`] = `
<img
alt="edX"
className="d-block"
src="https://edx-cdn.org/v3/default/logo-trademark.svg"
src="https://edx-cdn.org/v3/default/logo.svg"
/>
</a>
</div>
@@ -201,7 +201,7 @@ exports[`<Header /> renders correctly for authenticated desktop 1`] = `
<img
alt="edX"
className="d-block"
src="https://edx-cdn.org/v3/default/logo-trademark.svg"
src="https://edx-cdn.org/v3/default/logo.svg"
/>
</a>
<nav
@@ -360,7 +360,7 @@ exports[`<Header /> renders correctly for authenticated mobile 1`] = `
<img
alt="edX"
className="d-block"
src="https://edx-cdn.org/v3/default/logo-trademark.svg"
src="https://edx-cdn.org/v3/default/logo.svg"
/>
</a>
</div>