From 8109ba39bb6ced06fdb1dac4a856efd0b45fa3fa Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?R=C3=A9gis=20Behmo?= Date: Wed, 2 Apr 2025 12:48:48 +0200 Subject: [PATCH] =?UTF-8?q?chore:=20remove=20husky=20=F0=9F=AA=93?= =?UTF-8?q?=F0=9F=90=B6?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit We remove husky, which is triggering pre-push git hooks, including running "npm lint". This is causing failures when building Docker images, because "npm clean-install --omit=dev" automatically triggers "npm prepare", which attemps to run "husky". But husky is not listed in the build dependencies, only in devDependencies. As a consequence, package installation is failing with the following error: 14.13 > @edx/frontend-app-ora-grading@0.0.1 prepare 14.13 > husky install 14.13 14.15 sh: 1: husky: not found Similar to: https://github.com/openedx/frontend-app-learning/pull/1622 --- package-lock.json | 17 ----------------- package.json | 6 ------ 2 files changed, 23 deletions(-) diff --git a/package-lock.json b/package-lock.json index e27a877b..73fa09de 100644 --- a/package-lock.json +++ b/package-lock.json @@ -31,7 +31,6 @@ "@testing-library/jest-dom": "^5.16.4", "@testing-library/react": "^16.2.0", "@testing-library/user-event": "^14.6.1", - "husky": "8.0.3", "prop-types": "15.8.1", "react": "^18.3.1", "react-dom": "^18.3.1", @@ -13813,22 +13812,6 @@ "node": ">=10.17.0" } }, - "node_modules/husky": { - "version": "8.0.3", - "resolved": "https://registry.npmjs.org/husky/-/husky-8.0.3.tgz", - "integrity": "sha512-+dQSyqPh4x1hlO1swXBiNb2HzTDN1I2IGLQx1GrBuiqFJfoMrnZWwVmatvSiO+Iz8fBUnf+lekwNo4c2LlXItg==", - "dev": true, - "license": "MIT", - "bin": { - "husky": "lib/bin.js" - }, - "engines": { - "node": ">=14" - }, - "funding": { - "url": "https://github.com/sponsors/typicode" - } - }, "node_modules/hyperdyperid": { "version": "1.2.0", "resolved": "https://registry.npmjs.org/hyperdyperid/-/hyperdyperid-1.2.0.tgz", diff --git a/package.json b/package.json index f1236224..cf3bc066 100644 --- a/package.json +++ b/package.json @@ -19,11 +19,6 @@ "files": [ "/dist" ], - "husky": { - "hooks": { - "pre-commit": "npm run lint" - } - }, "repository": { "type": "git", "url": "git+https://github.com/openedx/frontend-component-footer.git" @@ -46,7 +41,6 @@ "@testing-library/react": "^16.2.0", "@testing-library/dom": "^10.4.0", "@testing-library/user-event": "^14.6.1", - "husky": "8.0.3", "prop-types": "15.8.1", "react": "^18.3.1", "react-dom": "^18.3.1",