diff --git a/.gitignore b/.gitignore index 360e5466..88a4720d 100644 --- a/.gitignore +++ b/.gitignore @@ -4,3 +4,5 @@ node_modules temp .idea/ + +src/i18n/transifex_input.json diff --git a/Makefile b/Makefile index 2d3601b6..9b699212 100755 --- a/Makefile +++ b/Makefile @@ -1,8 +1,5 @@ -extract_translations: ## no prerequisites so we can control order of operations - echo "We have to define this target due to tooling assumptions" - echo "Also we have to npm install using this hook b/c there's no other place for it in the current setup" +requirements: npm install - npm run-script i18n_extract i18n.extract: # Pulling display strings from .jsx files into .json files... @@ -12,6 +9,12 @@ i18n.concat: # Gathering JSON messages into one file... ./src/i18n/i18n-concat.js ./temp/src ./src/i18n/transifex_input.json + +# The following make targets are required by our tooling scripts found in: +# - https://github.com/edx/ecommerce-scripts/tree/master/transifex + +extract_translations: | requirements i18n.extract i18n.concat + detect_changed_source_translations: git diff --exit-code ./src/i18n/transifex_input.json @@ -19,7 +22,9 @@ tx_url1 = https://www.transifex.com/api/2/project/edx-platform/resource/frontend tx_url2 = https://www.transifex.com/api/2/project/edx-platform/resource/frontend-component-footer/source/ # push translations to Transifex, doing magic so we can include the translator comments -push_translations: | i18n.extract +# Note: extract_translations is a prereq that our translation script calls separately. +push_translations: + tx push -s # Adding translator comments... # Fetching strings from Transifex... ./node_modules/reactifex/bash_scripts/get_hashed_strings.sh $(tx_url1) diff --git a/src/i18n/transifex_input.json b/src/i18n/transifex_input.json deleted file mode 100644 index 388d0b35..00000000 --- a/src/i18n/transifex_input.json +++ /dev/null @@ -1,39 +0,0 @@ -{ - "footer.site-footer.link.about": "About", - "footer.site-footer.link.business": "{siteName} for Business", - "footer.site-footer.link.affiliates": "Affiliates", - "footer.site-footer.link.open-source": "Open {siteName}", - "footer.site-footer.link.careers": "Careers", - "footer.site-footer.link.news": "News", - "footer.site-footer.link.header.legal": "Legal", - "footer.site-footer.link.terms-of-service": "Terms of Service & Honor Code", - "footer.site-footer.link.privacy": "Privacy Policy", - "footer.site-footer.link.accessibility": "Accessibility Policy", - "footer.site-footer.link.trademark": "Trademark Policy", - "footer.site-footer.link.sitemap": "Sitemap", - "footer.site-footer.link.header.connect": "Connect", - "footer.site-footer.link.blog": "Blog", - "footer.site-footer.link.contact-us": "Contact Us", - "footer.site-footer.link.help-center": "Help Center", - "footer.site-footer.link.media-kit": "Media Kit", - "footer.site-footer.link.donate": "Donate", - "footer.site-footer.copyright-text": "{copyrightSymbol} {startDate}–{endDate} {siteName} Inc.", - "footer.site-footer.trademark-text": "EdX, Open edX, and MicroMasters are registered trademarks of edX Inc. | {icpLicense}", - "footer.site-footer.site-logo.alt-text": "{siteName} logo", - "footer.site-footer.site-logo.aria-label": "{siteName} Home", - "footer.site-footer.facebook.title": "Facebook", - "footer.site-footer.facebook.screen-reader-text": "Like {siteName} on Facebook", - "footer.site-footer.twitter.title": "Twitter", - "footer.site-footer.twitter.screen-reader-text": "Follow {siteName} on Twitter", - "footer.site-footer.youtube.title": "Youtube", - "footer.site-footer.youtube.screen-reader-text": "Subscribe to the {siteName} YouTube channel", - "footer.site-footer.linkedin.title": "LinkedIn", - "footer.site-footer.linkedin.screen-reader-text": "Follow {siteName} on LinkedIn", - "footer.site-footer.google-plus.title": "Google+", - "footer.site-footer.google-plus.screen-reader-text": "Follow {siteName} on Google+", - "footer.site-footer.reddit.title": "Reddit", - "footer.site-footer.reddit.screen-reader-text": "Subscribe to the {siteName} subreddit", - "footer.site-footer.apple-app-store.alt-text": "Download the {siteName} mobile app from the Apple App Store", - "footer.site-footer.google-play.alt-text": "Download the {siteName} mobile app from Google Play", - "footer.site-footer.footer.aria-label": "Page Footer" -} \ No newline at end of file