From 25d0ecb53194216e1444af75eb0790e53b5203f6 Mon Sep 17 00:00:00 2001 From: Justin Hynes Date: Mon, 30 Jan 2023 13:54:50 -0500 Subject: [PATCH] fix: remove learner record MFE URL building logic [APER-2240] The Profile MFE no longer needs to understand anything about the Learner Record MFE. The Credentials IDA now has logic to determine if a request should be redirected to the Learner Record MFE so we can remove these changes from the Profile MFE. --- .env | 2 -- .env.development | 2 -- .env.test | 2 -- src/index.jsx | 2 -- src/profile/ProfilePage.jsx | 17 ++--------------- 5 files changed, 2 insertions(+), 23 deletions(-) diff --git a/.env b/.env index b544657..b8c2875 100644 --- a/.env +++ b/.env @@ -22,8 +22,6 @@ LOGO_URL='' LOGO_TRADEMARK_URL='' LOGO_WHITE_URL='' FAVICON_URL='' -ENABLE_LEARNER_RECORD_MFE='' -LEARNER_RECORD_MFE_BASE_URL='' COLLECT_YEAR_OF_BIRTH=true APP_ID='' MFE_CONFIG_API_URL='' diff --git a/.env.development b/.env.development index 22f1dbd..2f52fd8 100644 --- a/.env.development +++ b/.env.development @@ -23,8 +23,6 @@ LOGO_URL=https://edx-cdn.org/v3/default/logo.svg LOGO_TRADEMARK_URL=https://edx-cdn.org/v3/default/logo-trademark.svg LOGO_WHITE_URL=https://edx-cdn.org/v3/default/logo-white.svg FAVICON_URL=https://edx-cdn.org/v3/default/favicon.ico -ENABLE_LEARNER_RECORD_MFE='' -LEARNER_RECORD_MFE_BASE_URL='http://localhost:1990' COLLECT_YEAR_OF_BIRTH=true APP_ID='' MFE_CONFIG_API_URL='' diff --git a/.env.test b/.env.test index 4e926bc..dc8c561 100644 --- a/.env.test +++ b/.env.test @@ -17,8 +17,6 @@ LOGO_URL=https://edx-cdn.org/v3/default/logo.svg LOGO_TRADEMARK_URL=https://edx-cdn.org/v3/default/logo-trademark.svg LOGO_WHITE_URL=https://edx-cdn.org/v3/default/logo-white.svg FAVICON_URL=https://edx-cdn.org/v3/default/favicon.ico -ENABLE_LEARNER_RECORD_MFE='' -LEARNER_RECORD_MFE_BASE_URL='http://localhost:1990' COLLECT_YEAR_OF_BIRTH=true APP_ID='' MFE_CONFIG_API_URL='' diff --git a/src/index.jsx b/src/index.jsx index 3a2ffd2..8dc15a0 100755 --- a/src/index.jsx +++ b/src/index.jsx @@ -65,8 +65,6 @@ initialize({ handlers: { config: () => { mergeConfig({ - ENABLE_LEARNER_RECORD_MFE: (process.env.ENABLE_LEARNER_RECORD_MFE || false), - LEARNER_RECORD_MFE_BASE_URL: process.env.LEARNER_RECORD_MFE_BASE_URL, COLLECT_YEAR_OF_BIRTH: process.env.COLLECT_YEAR_OF_BIRTH, ENABLE_SKILLS_BUILDER: process.env.ENABLE_SKILLS_BUILDER, }, 'App loadConfig override handler'); diff --git a/src/profile/ProfilePage.jsx b/src/profile/ProfilePage.jsx index a806aa0..c5c7604 100644 --- a/src/profile/ProfilePage.jsx +++ b/src/profile/ProfilePage.jsx @@ -46,10 +46,10 @@ class ProfilePage extends React.Component { constructor(props, context) { super(props, context); - const recordsUrl = this.getRecordsUrl(context); + const credentialsBaseUrl = context.config.CREDENTIALS_BASE_URL; this.state = { - viewMyRecordsUrl: recordsUrl, + viewMyRecordsUrl: credentialsBaseUrl ? `${credentialsBaseUrl}/records` : null, accountSettingsUrl: `${context.config.LMS_BASE_URL}/account/settings`, }; @@ -92,19 +92,6 @@ class ProfilePage extends React.Component { this.props.updateDraft(name, value); } - getRecordsUrl(context) { - let recordsUrl = null; - - if (getConfig().ENABLE_LEARNER_RECORD_MFE) { - recordsUrl = getConfig().LEARNER_RECORD_MFE_BASE_URL; - } else { - const credentialsBaseUrl = context.config.CREDENTIALS_BASE_URL; - recordsUrl = credentialsBaseUrl ? `${credentialsBaseUrl}/records` : null; - } - - return recordsUrl; - } - isYOBDisabled() { const { yearOfBirth } = this.props; const currentYear = new Date().getFullYear();