From 2483472f1c0bbf2089d26ae2bcbf0e8ea98c3bb7 Mon Sep 17 00:00:00 2001 From: Douglas Hall Date: Thu, 4 Apr 2019 13:55:45 -0400 Subject: [PATCH] Attempt to log the entire error object on request errors. --- src/services/LoggingService.js | 5 ++--- src/services/LoggingService.test.js | 2 +- 2 files changed, 3 insertions(+), 4 deletions(-) diff --git a/src/services/LoggingService.js b/src/services/LoggingService.js index 4cc4dc9..7e250d7 100644 --- a/src/services/LoggingService.js +++ b/src/services/LoggingService.js @@ -53,15 +53,14 @@ class LoggingService { } else if (error.request) { const { request } = error; const errorMessage = request.responseText || error.message; - const requestUrl = request.responseURL || (request.config && request.config.url); const requestAttributes = { errorType: 'api-request-error', errorStatus: request.status, - errorUrl: requestUrl, + errorUrl: request.responseURL, errorData: errorMessage, }; updatedCustomAttributes = Object.assign({}, requestAttributes, customAttributes); - processedError = new Error(`API request failed: ${request.status} ${requestUrl} ${errorMessage}`); + processedError = new Error(`API request failed: ${request.status} ${request.responseURL} ${errorMessage} ${JSON.stringify(error)}`); } this.logError(processedError, updatedCustomAttributes); diff --git a/src/services/LoggingService.test.js b/src/services/LoggingService.test.js index ba90674..c42b7e4 100644 --- a/src/services/LoggingService.test.js +++ b/src/services/LoggingService.test.js @@ -67,7 +67,7 @@ describe('logAPIErrorResponse', () => { }, }; const message = `${error.request.status} ${error.request.responseURL} ${error.request.responseText}`; - const expectedError = new Error(`API request failed: ${message}`); + const expectedError = new Error(`API request failed: ${message} ${JSON.stringify(error)}`); const expectedAttributes = { errorType: 'api-request-error', errorStatus: error.request.status,